[Libreoffice-commits] core.git: 3 commits - include/sfx2 sfx2/source

[Tor Lillqvist]

 include/sfx2/templateabstractview.hxx        |    4 ++--
 sfx2/source/control/templateabstractview.cxx |    3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 9d4bc00abbada676e17ff44c5bc1cc7a77765575
Author: Tor Lillqvist <tml at collabora.com>
Date:   Mon Jun 6 10:22:49 2016 +0300

    loplugin:staticmethods
    
    Change-Id: I1c178eedb1443372cdc474e36133400c0ad476ba

diff --git a/include/sfx2/templateabstractview.hxx b/include/sfx2/templateabstractview.hxx
index d10da23..e6029685 100644
--- a/include/sfx2/templateabstractview.hxx
+++ b/include/sfx2/templateabstractview.hxx
@@ -124,7 +124,7 @@ protected:
 
     virtual void OnItemDblClicked(ThumbnailViewItem *pItem) override;
 
-    bool IsDefaultTemplate(const OUString& rPath);
+    static bool IsDefaultTemplate(const OUString& rPath);
 
 protected:
 
commit d6efb4e417b3f85782c82fd97788db6b26740a19
Author: Tor Lillqvist <tml at collabora.com>
Date:   Mon Jun 6 10:21:56 2016 +0300

    loplugin:unusedvariablecheck
    
    Change-Id: Icbf2138d3ac69fb0022134fb7ceab34935ccdc2a

diff --git a/sfx2/source/control/templateabstractview.cxx b/sfx2/source/control/templateabstractview.cxx
index e9656f3..5d95c37 100644
--- a/sfx2/source/control/templateabstractview.cxx
+++ b/sfx2/source/control/templateabstractview.cxx
@@ -254,7 +254,6 @@ BitmapEx TemplateAbstractView::scaleImg (const BitmapEx &rImg, long width, long
 bool TemplateAbstractView::IsDefaultTemplate(const OUString& rPath)
 {
     SvtModuleOptions aModOpt;
-    std::vector<OUString> aList;
     const css::uno::Sequence<OUString> &aServiceNames = aModOpt.GetAllServiceNames();
 
     for( sal_Int32 i=0, nCount = aServiceNames.getLength(); i < nCount; ++i )
commit 043b2900aed2f6e2c22e90710302b15afec312b4
Author: Tor Lillqvist <tml at collabora.com>
Date:   Mon Jun 6 10:17:46 2016 +0300

    loplugin:passstuffbyref
    
    Change-Id: Ie1cd7d63aaf2963137138def86cf5f4e141569b2

diff --git a/include/sfx2/templateabstractview.hxx b/include/sfx2/templateabstractview.hxx
index 53641a7..d10da23 100644
--- a/include/sfx2/templateabstractview.hxx
+++ b/include/sfx2/templateabstractview.hxx
@@ -112,7 +112,7 @@ public:
     long getThumbnailWidth() const  { return mnThumbnailWidth;}
     long getThumbnailHeight() const {return mnThumbnailHeight;}
 
-    void RemoveDefaultTemplateIcon( OUString rPath);
+    void RemoveDefaultTemplateIcon( const OUString& rPath);
 
     static BitmapEx scaleImg (const BitmapEx &rImg, long width, long height);
 
diff --git a/sfx2/source/control/templateabstractview.cxx b/sfx2/source/control/templateabstractview.cxx
index a9f358b..e9656f3 100644
--- a/sfx2/source/control/templateabstractview.cxx
+++ b/sfx2/source/control/templateabstractview.cxx
@@ -267,7 +267,7 @@ bool TemplateAbstractView::IsDefaultTemplate(const OUString& rPath)
     return false;
 }
 
-void TemplateAbstractView::RemoveDefaultTemplateIcon( OUString rPath)
+void TemplateAbstractView::RemoveDefaultTemplateIcon(const OUString& rPath)
 {
     for (ThumbnailViewItem* pItem : mItemList)
     {