[Libreoffice-commits] core.git: include/svx svx/source

Xisco Fauli anistenis at gmail.com
Tue Jun 7 06:58:01 UTC 2016


 include/svx/fmpage.hxx     |    2 +-
 svx/source/form/fmpage.cxx |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 8dc73a2c0801db12b0d03a54c7ec59b12f1276e3
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Mon Jun 6 00:33:37 2016 +0200

    tdf#89329: use unique_ptr for pImpl in fmpage
    
    Change-Id: I47bc9c2e70ddad5d560cc41db645d9a7085a9aa9
    Reviewed-on: https://gerrit.libreoffice.org/25936
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/include/svx/fmpage.hxx b/include/svx/fmpage.hxx
index 044665d..851e3e4 100644
--- a/include/svx/fmpage.hxx
+++ b/include/svx/fmpage.hxx
@@ -43,7 +43,7 @@ class SVX_DLLPUBLIC FmFormPage : public SdrPage
     FmFormPage& operator=(const FmFormPage&) = delete;
 
     friend class FmFormObj;
-    FmFormPageImpl*     m_pImpl;
+    std::unique_ptr<FmFormPageImpl>     m_pImpl;
     OUString            m_sPageName;
 
 public:
diff --git a/svx/source/form/fmpage.cxx b/svx/source/form/fmpage.cxx
index 4869369..de5aa87 100644
--- a/svx/source/form/fmpage.cxx
+++ b/svx/source/form/fmpage.cxx
@@ -73,7 +73,6 @@ void FmFormPage::lateInit(const FmFormPage& rPage, FmFormModel* const pNewModel)
 
 FmFormPage::~FmFormPage()
 {
-    delete m_pImpl;
 }
 
 


More information about the Libreoffice-commits mailing list