[Libreoffice-commits] core.git: include/svx svx/source

Xisco Fauli anistenis at gmail.com
Tue Jun 7 06:58:44 UTC 2016


 include/svx/svdobj.hxx       |    2 +-
 svx/source/svdraw/svdobj.cxx |    2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

New commits:
commit a5e7c9ca89c5bf5664a687650ce0a94d7764e2b8
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Mon Jun 6 00:55:54 2016 +0200

    tdf#89329: use unique_ptr for pImpl in svdobj
    
    Change-Id: I2126e54b6b4571a490819bac0aff2bd10f766ffd
    Reviewed-on: https://gerrit.libreoffice.org/25941
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 3b8c5b9..27357e2 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -261,7 +261,7 @@ class SVX_DLLPUBLIC SdrObject: public SfxListener, public tools::WeakBase< SdrOb
 {
 private:
     struct Impl;
-    Impl* mpImpl;
+    std::unique_ptr<Impl> mpImpl;
 
     SdrObject( const SdrObject& ) = delete;
 
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx
index 0316c9a..b2124b5c 100644
--- a/svx/source/svdraw/svdobj.cxx
+++ b/svx/source/svdraw/svdobj.cxx
@@ -379,8 +379,6 @@ SdrObject::~SdrObject()
         delete mpViewContact;
         mpViewContact = nullptr;
     }
-
-    delete mpImpl;
 }
 
 void SdrObject::Free( SdrObject*& _rpObject )


More information about the Libreoffice-commits mailing list