[Libreoffice-commits] core.git: include/svx svx/source
Xisco Fauli
anistenis at gmail.com
Tue Jun 7 06:59:53 UTC 2016
include/svx/float3d.hxx | 2 +-
svx/source/engine3d/float3d.cxx | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit ca1d1c41f1dd4702bdffb1936b85bb6ac617219a
Author: Xisco Fauli <anistenis at gmail.com>
Date: Mon Jun 6 00:35:58 2016 +0200
tdf#89329: use unique_ptr for pImpl in float3d
Change-Id: I80eb64cd91651f521fb6dba6bef22dc1d77188e1
Reviewed-on: https://gerrit.libreoffice.org/25937
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
diff --git a/include/svx/float3d.hxx b/include/svx/float3d.hxx
index 6f22ef7..ecbeb48 100644
--- a/include/svx/float3d.hxx
+++ b/include/svx/float3d.hxx
@@ -179,7 +179,7 @@ private:
SvxConvertTo3DItem* pConvertTo3DItem;
SvxConvertTo3DItem* pConvertTo3DLatheItem;
- Svx3DWinImpl* mpImpl;
+ std::unique_ptr<Svx3DWinImpl> mpImpl;
SfxMapUnit ePoolUnit;
FieldUnit eFUnit;
diff --git a/svx/source/engine3d/float3d.cxx b/svx/source/engine3d/float3d.cxx
index bd103da..d5e1304 100644
--- a/svx/source/engine3d/float3d.cxx
+++ b/svx/source/engine3d/float3d.cxx
@@ -336,7 +336,7 @@ void Svx3DWin::dispose()
delete mpRemember2DAttributes;
- delete mpImpl;
+ mpImpl.reset();
m_pBtnGeo.clear();
m_pBtnRepresentation.clear();
More information about the Libreoffice-commits
mailing list