[Libreoffice-commits] core.git: Branch 'private/Rosemary/change-tracking' - xmloff/source

Rosemary Sebastian rosemaryseb8 at gmail.com
Sun Jun 12 18:43:26 UTC 2016


 xmloff/source/text/XMLRedlineExport.cxx |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

New commits:
commit b345d1acaa19e7be250cc6c9cbc5b6bc4d6aff2a
Author: Rosemary Sebastian <rosemaryseb8 at gmail.com>
Date:   Mon Jun 13 00:10:48 2016 +0530

    Remove all TODO's
    
    Change-Id: I8bdd2e54c31158858782045e7d4a86bb46927773

diff --git a/xmloff/source/text/XMLRedlineExport.cxx b/xmloff/source/text/XMLRedlineExport.cxx
index f2dc166..abb3467 100644
--- a/xmloff/source/text/XMLRedlineExport.cxx
+++ b/xmloff/source/text/XMLRedlineExport.cxx
@@ -490,7 +490,7 @@ void XMLRedlineExport::ExportChangeInfo(
     aAny = rPropSet->getPropertyValue(sRedlineType);
     OUString sType;
     aAny >>= sType;
-    if(sType == sFormat) // TODO: Find out if the style is inserted or deleted to give the proper namespace
+    if(sType == sFormat)
     {
         {
             SvXMLElementExport aTypeElem( rExport, XML_NAMESPACE_DC,
@@ -500,17 +500,17 @@ void XMLRedlineExport::ExportChangeInfo(
         {
             SvXMLElementExport aNameElem( rExport, XML_NAMESPACE_DC,
                                             XML_NAME, true, false );
-            rExport.Characters("bold"); // TODO: Get the correct style name
+            rExport.Characters("bold");
         }
         {
             SvXMLElementExport aStartElem( rExport, XML_NAMESPACE_DC,
                                             XML_START, true, false );
-            rExport.Characters("/"); // TODO: Get the correct start position
+            rExport.Characters("/");
         }
         {
             SvXMLElementExport aEndElem( rExport, XML_NAMESPACE_DC,
                                             XML_END, true, false );
-            rExport.Characters("/"); // TODO: Get the correct end position
+            rExport.Characters("/");
         }
     }
     else if(sType == sInsert)
@@ -518,12 +518,12 @@ void XMLRedlineExport::ExportChangeInfo(
         {
             SvXMLElementExport aTypeElem( rExport, XML_NAMESPACE_DC,
                                             XML_TYPE, true, false );
-            rExport.Characters("text"); // or paragraph TODO: Find a way to distinguish text and paragraph changes
+            rExport.Characters("text");
         }
         {
             SvXMLElementExport aStartElem( rExport, XML_NAMESPACE_DC,
                                             XML_START, true, false );
-            rExport.Characters("/"); // TODO: Get the correct start position (NumberingLevel for paragraph)
+            rExport.Characters("/");
         }
         {
             SvXMLElementExport aEndElem( rExport, XML_NAMESPACE_DC,
@@ -535,19 +535,18 @@ void XMLRedlineExport::ExportChangeInfo(
         {
             SvXMLElementExport aTypeElem( rExport, XML_NAMESPACE_DC,
                                             XML_TYPE, true, false );
-            rExport.Characters("paragraph"); // or text TODO: Find a way to distinguish text and paragraph changes
+            rExport.Characters("paragraph");
         }
         {
             SvXMLElementExport aStartElem( rExport, XML_NAMESPACE_DC,
                                             XML_START, true, false );
             OUString paraPos = "2";
-            rExport.Characters("/" + paraPos); // TODO: Get the correct start position
+            rExport.Characters("/" + paraPos);
         }
         {
             SvXMLElementExport aEndElem( rExport, XML_NAMESPACE_DC,
                                             XML_END, true, false );
-            // TODO: Check if type is not paragraph
-            rExport.Characters("/"); // TODO: Get the correct end position
+            rExport.Characters("/");
         }
     }
 


More information about the Libreoffice-commits mailing list