[Libreoffice-commits] core.git: dbaccess/source

[Caolán McNamara]

 dbaccess/source/ui/uno/copytablewizard.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b3e939971f56d53e60448a954a616ec295544098
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Jun 11 20:40:01 2016 +0100

    coverity#1362680 Pointer to local outside scope
    
    this doesn't seem to make sense anymore since...
    
    commit 4d49c9601c9b3e26a336e08e057d299895683480
    Author: Stephan Bergmann <sbergman at redhat.com>
    Date:   Wed Jun 8 17:14:34 2016 +0200
    
        Let loplugin:passstuffbyref also look at fn defn not preceded by any decl
    
    so lets revert that to be safe
    
    Change-Id: I78fe8ae48dc4c4f3d5786c7232d7e791ff50d9b4
    Reviewed-on: https://gerrit.libreoffice.org/26189
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/dbaccess/source/ui/uno/copytablewizard.cxx b/dbaccess/source/ui/uno/copytablewizard.cxx
index 4e61431..08f714a 100644
--- a/dbaccess/source/ui/uno/copytablewizard.cxx
+++ b/dbaccess/source/ui/uno/copytablewizard.cxx
@@ -966,7 +966,7 @@ namespace
     class ValueTransfer
     {
     public:
-        ValueTransfer( sal_Int32 _rSourcePos, sal_Int32 _rDestPos, const ::std::vector< sal_Int32 >& _rColTypes,
+        ValueTransfer( const sal_Int32& _rSourcePos, const sal_Int32& _rDestPos, const ::std::vector< sal_Int32 >& _rColTypes,
             const Reference< XRow >& _rxSource, const Reference< XParameters >& _rxDest )
             :m_rSourcePos( _rSourcePos )
             ,m_rDestPos( _rDestPos )