[Libreoffice-commits] core.git: cui/source
Miklos Vajna
vmiklos at collabora.co.uk
Fri Jun 17 14:15:06 UTC 2016
cui/source/inc/cuitabarea.hxx | 4 ++--
cui/source/tabpages/tpgradnt.cxx | 4 ++--
cui/source/tabpages/tphatch.cxx | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit eb0fb156e483bf20cb046f0226f0fc363c37f91a
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date: Fri Jun 17 16:13:56 2016 +0200
cui: fix loplugin:passstuffbyref warnings
Change-Id: Ic756db3decb4b4bfde345bc0adc092907622287e
diff --git a/cui/source/inc/cuitabarea.hxx b/cui/source/inc/cuitabarea.hxx
index 98f2c32..b382e72 100644
--- a/cui/source/inc/cuitabarea.hxx
+++ b/cui/source/inc/cuitabarea.hxx
@@ -429,7 +429,7 @@ private:
long CheckChanges_Impl();
void SetControlState_Impl( css::awt::GradientStyle eXGS );
- sal_Int32 SearchGradientList(OUString aGradientName);
+ sal_Int32 SearchGradientList(const OUString& rGradientName);
public:
SvxGradientTabPage( vcl::Window* pParent, const SfxItemSet& rInAttrs );
@@ -512,7 +512,7 @@ private:
DECL_LINK_TYPED( ClickSaveHdl_Impl, Button*, void );
long CheckChanges_Impl();
- sal_Int32 SearchHatchList(OUString aHatchName);
+ sal_Int32 SearchHatchList(const OUString& rHatchName);
public:
SvxHatchTabPage( vcl::Window* pParent, const SfxItemSet& rInAttrs );
diff --git a/cui/source/tabpages/tpgradnt.cxx b/cui/source/tabpages/tpgradnt.cxx
index 6ab4d12..a5aad0a 100644
--- a/cui/source/tabpages/tpgradnt.cxx
+++ b/cui/source/tabpages/tpgradnt.cxx
@@ -927,7 +927,7 @@ void SvxGradientTabPage::SetControlState_Impl( css::awt::GradientStyle eXGS )
}
}
-sal_Int32 SvxGradientTabPage::SearchGradientList(OUString aGradientName)
+sal_Int32 SvxGradientTabPage::SearchGradientList(const OUString& rGradientName)
{
long nCount = m_pGradientList->Count();
bool bValidGradientName = true;
@@ -935,7 +935,7 @@ sal_Int32 SvxGradientTabPage::SearchGradientList(OUString aGradientName)
for(long i = 0;i < nCount && bValidGradientName;i++)
{
- if(aGradientName == m_pGradientList->GetGradient( i )->GetName())
+ if(rGradientName == m_pGradientList->GetGradient( i )->GetName())
{
nPos = i;
bValidGradientName = false;
diff --git a/cui/source/tabpages/tphatch.cxx b/cui/source/tabpages/tphatch.cxx
index a1a2c2b..489ab78 100644
--- a/cui/source/tabpages/tphatch.cxx
+++ b/cui/source/tabpages/tphatch.cxx
@@ -313,7 +313,7 @@ long SvxHatchTabPage::CheckChanges_Impl()
return 0L;
}
-sal_Int32 SvxHatchTabPage::SearchHatchList(OUString aHatchName)
+sal_Int32 SvxHatchTabPage::SearchHatchList(const OUString& rHatchName)
{
long nCount = m_pHatchingList->Count();
bool bValidHatchName = true;
@@ -321,7 +321,7 @@ sal_Int32 SvxHatchTabPage::SearchHatchList(OUString aHatchName)
for(long i = 0;i < nCount && bValidHatchName;i++)
{
- if(aHatchName == m_pHatchingList->GetHatch( i )->GetName())
+ if(rHatchName == m_pHatchingList->GetHatch( i )->GetName())
{
nPos = i;
bValidHatchName = false;
More information about the Libreoffice-commits
mailing list