[Libreoffice-commits] core.git: sc/source

Muhammet Kara muhammet.kara at pardus.org.tr
Sat Jun 18 09:23:56 UTC 2016


 sc/source/ui/navipi/navipi.cxx |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

New commits:
commit 1801c00d39a911d80edbb59e0895974297f1373b
Author: Muhammet Kara <muhammet.kara at pardus.org.tr>
Date:   Sat Jun 18 08:35:06 2016 +0300

    Improve readability of OUString concatanation in ScNavigatorDlg
    
    It is more readable and more efficient as a bonus.
    See: https://goo.gl/jsVAwy:
    
    Change-Id: I0831b2f6ab2912a15ff33397a7959596b7bd3cb8
    Reviewed-on: https://gerrit.libreoffice.org/26451
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/sc/source/ui/navipi/navipi.cxx b/sc/source/ui/navipi/navipi.cxx
index 862b985..12c81b7 100644
--- a/sc/source/ui/navipi/navipi.cxx
+++ b/sc/source/ui/navipi/navipi.cxx
@@ -581,16 +581,15 @@ ScNavigatorDlg::ScNavigatorDlg( SfxBindings* pB, SfxChildWindowContext* pCW, vcl
     //  eListMode is set from outside, Root further below
 
     aLbDocuments->SetDropDownLineCount(9);
-    OUString aOpen(" (");
-    aStrActive = aOpen;
-    aStrActive += OUString( ScResId( STR_ACTIVE ) );
-    aStrActive += ")";                                      // " (active)"
-    aStrNotActive = aOpen;
-    aStrNotActive += OUString( ScResId( STR_NOTACTIVE ) );
-    aStrNotActive += ")";                                   // " (not active)"
-    aStrHidden = aOpen;
-    aStrHidden += OUString( ScResId( STR_HIDDEN ) );
-    aStrHidden += ")";                                      // " (hidden)"
+    aStrActive    = " ("
+                  + OUString( ScResId( STR_ACTIVE ) )
+                  + ")";                                      // " (active)"
+    aStrNotActive = " ("
+                  + OUString( ScResId( STR_NOTACTIVE ) )
+                  + ")";                                   // " (not active)"
+    aStrHidden    = " ("
+                  + OUString( ScResId( STR_HIDDEN ) )
+                  + ")";                                      // " (hidden)"
 
     aTitleBase = GetText();
 


More information about the Libreoffice-commits mailing list