[Libreoffice-commits] core.git: unotools/source

Xisco Fauli anistenis at gmail.com
Mon Jun 20 10:54:59 UTC 2016


 unotools/source/config/defaultoptions.cxx |    2 +-
 unotools/source/config/misccfg.cxx        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit fb784cf569ad2a27d844d7c52f8a804aa2f8deaa
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Wed Jun 15 00:50:57 2016 +0200

    Mark these functions as final
    
    Comment from Michael Stahl in Gerrit:
    "to prevent potential disasters if somebody adds
    a sub-class and overrides ImplCommit,
    which is then not called here."
    
    Change-Id: I2d991c713734fd516827a5dd6c8929aa64e59409
    Reviewed-on: https://gerrit.libreoffice.org/26278
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Tested-by: Michael Stahl <mstahl at redhat.com>

diff --git a/unotools/source/config/defaultoptions.cxx b/unotools/source/config/defaultoptions.cxx
index 0bcba50..5d0ad67 100644
--- a/unotools/source/config/defaultoptions.cxx
+++ b/unotools/source/config/defaultoptions.cxx
@@ -99,7 +99,7 @@ public:
     virtual void    Notify( const css::uno::Sequence<OUString>& aPropertyNames) override;
 
 private:
-    virtual void    ImplCommit() override;
+    virtual void    ImplCommit() final override;
 };
 
 // global ----------------------------------------------------------------
diff --git a/unotools/source/config/misccfg.cxx b/unotools/source/config/misccfg.cxx
index d50542c..afb59da 100644
--- a/unotools/source/config/misccfg.cxx
+++ b/unotools/source/config/misccfg.cxx
@@ -46,7 +46,7 @@ private:
     static const css::uno::Sequence<OUString> GetPropertyNames();
     void                    Load();
 
-    virtual void            ImplCommit() override;
+    virtual void            ImplCommit() final override;
 
 public:
     SfxMiscCfg( );


More information about the Libreoffice-commits mailing list