[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/qa sc/source

[Caolán McNamara]

 sc/qa/unit/ucalc.cxx             |    6 ++++++
 sc/source/core/data/column4.cxx  |    2 +-
 sc/source/ui/unoobj/cellsuno.cxx |   10 ++++++++++
 3 files changed, 17 insertions(+), 1 deletion(-)

New commits:
commit b8b51fc4b253b3468396addd3bf72766d6d82710
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Jun 23 10:24:49 2016 +0100

    Resolves: tdf#100460 queryContentCells doesn't count annotations...
    
    since
    
    commit c06dbbe7594c2a0b5a5b19f8e183d9c421e6e094
    Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Date:   Thu Feb 23 23:36:49 2012 +0100
    
        remove mpNote from ScBaseCell
    
    Change-Id: I281a207e26aec8886b1f46b9279e1135b61586da
    (cherry picked from commit 83f977c7f40d1a5fb975b8ce7c9958c992dba3f1)
    
    Related: tdf#100460 GetNotesInRange doesn't count last cell in range
    
    e.g. open document from tdf#100460 and select select A20:A21 and right click
    and there is a hide comment entry. Shrink the selection to just A20 (which has
    the comment in it) and the right click menu has no hide comment entry in it.
    
    std::for_each(it, itEnd
    
    means it < itEnd but here we want the rows indicated by
    
    nStartRow <= nEndRow
    
    so we need to increment itEnd by one to get the right range
    
    Change-Id: I48e8c0748f520671e09f04b16961bf9729960317
    (cherry picked from commit 84dc0157df9cb173ec74da2bd27507329efc3816)
    Reviewed-on: https://gerrit.libreoffice.org/26608
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 9cecacc..5a38c92 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -4980,6 +4980,12 @@ void Test::testNoteCopyPaste()
     CPPUNIT_ASSERT(pNote);
     CPPUNIT_ASSERT_EQUAL(OUString("Note2"), pNote->GetText());
 
+    // Test that GetNotesInRange includes the end of its range
+    // and so can find the note
+    std::vector<sc::NoteEntry> aNotes;
+    m_pDoc->GetNotesInRange(ScRange(1,7,0), aNotes);
+    CPPUNIT_ASSERT_EQUAL(size_t(1), aNotes.size());
+
     m_pDoc->DeleteTab(0);
 }
 
diff --git a/sc/source/core/data/column4.cxx b/sc/source/core/data/column4.cxx
index e145e75..6e8e4da 100644
--- a/sc/source/core/data/column4.cxx
+++ b/sc/source/core/data/column4.cxx
@@ -701,7 +701,7 @@ void ScColumn::GetNotesInRange(SCROW nStartRow, SCROW nEndRow,
         maCellNotes.position(nEndRow);
     sc::CellNoteStoreType::const_iterator itEnd = aEndPos.first;
 
-    std::for_each(it, itEnd, NoteEntryCollector(rNotes, nTab, nCol, nStartRow, nEndRow));
+    std::for_each(it, ++itEnd, NoteEntryCollector(rNotes, nTab, nCol, nStartRow, nEndRow));
 }
 
 namespace {
diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index 944c56d..de019bf 100644
--- a/sc/source/ui/unoobj/cellsuno.cxx
+++ b/sc/source/ui/unoobj/cellsuno.cxx
@@ -3601,7 +3601,17 @@ uno::Reference<sheet::XSheetCellRanges> SAL_CALL ScCellRangesBase::queryContentC
                 if (bAdd)
                     aMarkData.SetMultiMarkArea(aIter.GetPos());
             }
+        }
+
+        if (nContentFlags & sheet::CellFlags::ANNOTATION)
+        {
+            std::vector<sc::NoteEntry> aNotes;
+            rDoc.GetNotesInRange(aRanges, aNotes);
 
+            for (const auto& i : aNotes)
+            {
+                aMarkData.SetMultiMarkArea(i.maPos);
+            }
         }
 
         ScRangeList aNewRanges;