[Libreoffice-commits] core.git: comphelper/source

Muhammet Kara muhammet.kara at pardus.org.tr
Tue Jun 28 06:29:38 UTC 2016


 comphelper/source/misc/storagehelper.cxx |   20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 41bc79521eadb0c39b8f208ba6fe32b82ef1ed42
Author: Muhammet Kara <muhammet.kara at pardus.org.tr>
Date:   Mon Jun 27 17:09:39 2016 +0300

    Improve readability of OUString concatanation in OStorageHelper
    
    It is more readable and more efficient as a bonus.
    See: https://goo.gl/jsVAwy:
    
    Change-Id: I5cc22276fc385a381d64e00f20d6d2b302ea587f
    Reviewed-on: https://gerrit.libreoffice.org/26720
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/comphelper/source/misc/storagehelper.cxx b/comphelper/source/misc/storagehelper.cxx
index 35756dc..4730794 100644
--- a/comphelper/source/misc/storagehelper.cxx
+++ b/comphelper/source/misc/storagehelper.cxx
@@ -275,12 +275,12 @@ sal_Int32 OStorageHelper::GetXStorageFormat(
     else
     {
         // the mediatype is not known
-        OUString aMsg(OSL_THIS_FUNC);
-        aMsg += ":";
-        aMsg += OUString::number(__LINE__);
-        aMsg += ": unknown media type '";
-        aMsg += aMediaType;
-        aMsg += "'";
+        OUString aMsg = OUString(OSL_THIS_FUNC)
+                      + ":"
+                      + OUString::number(__LINE__)
+                      + ": unknown media type '"
+                      + aMediaType
+                      + "'";
         throw beans::IllegalTypeException(aMsg);
     }
 
@@ -479,11 +479,11 @@ bool OStorageHelper::PathHasSegment( const OUString& aPath, const OUString& aSeg
 
     if ( !aSegment.isEmpty() && nPathLen >= nSegLen )
     {
-        OUString aEndSegment( "/" );
-        aEndSegment += aSegment;
+        OUString aEndSegment = "/"
+                             + aSegment;
 
-        OUString aInternalSegment( aEndSegment );
-        aInternalSegment += "/";
+        OUString aInternalSegment = aEndSegment
+                                  + "/";
 
         if ( aPath.indexOf( aInternalSegment ) >= 0 )
             bResult = true;


More information about the Libreoffice-commits mailing list