[Libreoffice-commits] core.git: tools/source

[Tor Lillqvist]

 tools/source/generic/fract.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit b5dfe9b95fa0f995542c151d8e1b79a03e91c626
Author: Tor Lillqvist <tml at collabora.com>
Date:   Tue Jun 28 13:40:25 2016 +0300

    Drop overflow warning that was produced repeatedly on Windows
    
    I see hundreds of the "'operator *=' detected overflow" warnings on
    Windows doing perfectly normal things. The call site for those
    explicitly checks anyway for an invalid (overflowed) result.
    
    (Sure, there might be other call sites where the warning possibly had
    some degree of usefulness because an overflowed result is not checked
    for. I am willing to take the risk.)
    
    Change-Id: Ie88ad11d159ee7aa505c22633a7e2cda1246ff31

diff --git a/tools/source/generic/fract.cxx b/tools/source/generic/fract.cxx
index 12530c7..78069a5 100644
--- a/tools/source/generic/fract.cxx
+++ b/tools/source/generic/fract.cxx
@@ -182,7 +182,6 @@ Fraction& Fraction::operator *= ( const Fraction& rVal )
     if ( HasOverflowValue() )
     {
         mpImpl->valid = false;
-        SAL_WARN( "tools.fraction", "'operator *=' detected overflow" );
     }
 
     return *this;