[Libreoffice-commits] core.git: Branch 'feature/dialog-screenshots' - 2 commits - sc/Module_sc.mk sc/qa sd/Module_sd.mk

[Katarina Behrens]

 sc/Module_sc.mk                        |    1 +
 sc/qa/unit/screenshots/screenshots.cxx |    2 +-
 sd/Module_sd.mk                        |    4 ++++
 3 files changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 06d36ffdaeb387a6014deb8c85fa355a2ffcb2a6
Author: Katarina Behrens <Katarina.Behrens at cib.de>
Date:   Wed Jun 29 17:48:42 2016 +0200

    Take screenshots during 'make slowcheck'
    
    Change-Id: I666dfcb451367f5ac9f36207703cf090c1846b35

diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index 0f6b29f..1e410d9 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -59,6 +59,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sc, \
 	CppunitTest_sc_opencl_test \
 	CppunitTest_sc_copypaste \
 	CppunitTest_sc_functions_test \
+	CppunitTest_sc_screenshots \
 ))
 
 # Disabled to allow the check tinderbox execute the sd tests
diff --git a/sd/Module_sd.mk b/sd/Module_sd.mk
index 80f31fa..5e067d3 100644
--- a/sd/Module_sd.mk
+++ b/sd/Module_sd.mk
@@ -44,6 +44,10 @@ $(eval $(call gb_Module_add_check_targets,sd,\
 ))
 endif
 
+$(eval $(call gb_Module_add_slowcheck_targets,sd, \
+    CppunitTest_sd_dialogs_test \
+))
+
 $(eval $(call gb_Module_add_subsequentcheck_targets,sd,\
     JunitTest_sd_unoapi \
 ))
commit beb604fe5258350e004a8f9c8c739e0b63c79b55
Author: Katarina Behrens <Katarina.Behrens at cib.de>
Date:   Wed Jun 29 14:40:23 2016 +0200

    Don't leak windows
    
    Change-Id: If39441d6419556d1ae7637626b17b81357d29c38

diff --git a/sc/qa/unit/screenshots/screenshots.cxx b/sc/qa/unit/screenshots/screenshots.cxx
index 46a5af2..d331ffa 100644
--- a/sc/qa/unit/screenshots/screenshots.cxx
+++ b/sc/qa/unit/screenshots/screenshots.cxx
@@ -339,7 +339,7 @@ void ScScreenshotTest::testOpeningModalDialogs()
 
     for ( sal_uInt32 i = 0; i < nDialogs; i++ )
     {
-        VclAbstractDialog *pDialog = createDialogByID( i );
+        std::unique_ptr<VclAbstractDialog> pDialog( createDialogByID( i ) );
 
         dumpDialogToPath( *pDialog );
     }