[Libreoffice-commits] core.git: libreofficekit/source

Miklos Vajna vmiklos at collabora.co.uk
Thu Jun 30 07:46:13 UTC 2016


 libreofficekit/source/gtk/lokdocview.cxx |    4 ----
 1 file changed, 4 deletions(-)

New commits:
commit bfd4234fd863ee75f4f07d9bded061063bbde3d4
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Thu Jun 30 09:13:52 2016 +0200

    lokdocview: avoid pointless setView() before getView()
    
    This fixes the following use-case:
    
    1) Start gtktiledviewer, click New View
    2) Click Edit in the first view
    3) Click somewhere in the document in the first view -> nothing happens
    
    Change-Id: I79d63538607f03b78851a639adf158d918745276
    Reviewed-on: https://gerrit.libreoffice.org/26789
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/libreofficekit/source/gtk/lokdocview.cxx b/libreofficekit/source/gtk/lokdocview.cxx
index c27a1f9..8e2d278 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -848,10 +848,6 @@ static gboolean postDocumentLoad(gpointer pData)
     LOKDocViewPrivate& priv = getPrivate(pLOKDocView);
 
     std::unique_lock<std::mutex> aGuard(g_aLOKMutex);
-    std::stringstream ss;
-    ss << "lok::Document::setView(" << priv->m_nViewId << ")";
-    g_info("%s", ss.str().c_str());
-    priv->m_pDocument->pClass->setView(priv->m_pDocument, priv->m_nViewId);
     priv->m_pDocument->pClass->initializeForRendering(priv->m_pDocument, priv->m_aRenderingArguments.c_str());
     priv->m_nViewId = priv->m_pDocument->pClass->getView(priv->m_pDocument);
     priv->m_pDocument->pClass->registerCallback(priv->m_pDocument, callbackWorker, pLOKDocView);


More information about the Libreoffice-commits mailing list