[Libreoffice-commits] online.git:

[Tor Lillqvist]

 0 files changed

New commits:
commit 3671abf89b376555394b22bfee25d450e7eff5f6
Author: Tor Lillqvist <tml at collabora.com>
Date:   Thu Mar 3 17:44:00 2016 +0200

    Describe what 2fab7574626919d66c637f40302cb00e8d280b3f fixes
    
    I forgot to mention in the commit message of
    2fab7574626919d66c637f40302cb00e8d280b3f what error situation the
    change fixes... So here goes:
    
    If a client session closes just after sending a load message to load a
    document, and another session then fairly immediately connects and
    sends a load message for the same document, the latter session gets
    handled by the same kit process. Also the same Document object is
    apparently used. In that kit process, the documentLoad() can still be
    in progress. The handler for the new session still calls onLoad(),
    too, and as the onLoad() had dropped the lock for the duration of the
    documentLoad() call, the new onLoad gets the lock and calls
    documentLoad(), too, while the documentLoad() call in the other thread
    still is in progress. This leads to interesting problems.
    
    Actually, now that I think of it, I very much doubt it is sane to have
    the same Document object used for several sessions (one or several
    already "dead" ones and one "live" one) simultaneously, but at least
    the change made the unit test work more reliably.