[Libreoffice-commits] core.git: qadevOOo/runner

Stephan Bergmann sbergman at redhat.com
Fri Mar 4 13:24:13 UTC 2016


 qadevOOo/runner/helper/OfficeProvider.java |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9dcd54014c315586e8c1aae08c6079dac7acb0b6
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Mar 4 14:21:22 2016 +0100

    cid#1327083 SWL: Sleep with lock held
    
    It's unclear to me why the disposeOffice method was marked "synchronized" in the
    first place with fbd72be142ed23b3b526c8d0c3e002f15ca7ec74 "INTEGRATION: CWS
    qadev16: #114831#."  Maybe just some cluelessness?  Lets see whether we ever run
    into any problems after removing it.
    
    Change-Id: I1f262b6b4b4f4e8911754a6b3fa3d61f5df0aeae

diff --git a/qadevOOo/runner/helper/OfficeProvider.java b/qadevOOo/runner/helper/OfficeProvider.java
index 26d0528..584c4ca 100644
--- a/qadevOOo/runner/helper/OfficeProvider.java
+++ b/qadevOOo/runner/helper/OfficeProvider.java
@@ -434,7 +434,7 @@ public class OfficeProvider implements AppProvider
         return msf;
     }
 
-    private synchronized boolean disposeOffice(XMultiServiceFactory msf,
+    private boolean disposeOffice(XMultiServiceFactory msf,
             TestParameters param)
     {
         XDesktop desk = null;


More information about the Libreoffice-commits mailing list