[Libreoffice-commits] core.git: fpicker/source

Stephan Bergmann sbergman at redhat.com
Fri Mar 4 15:59:18 UTC 2016


 fpicker/source/win32/filepicker/asyncrequests.hxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 788afcfb4d0895593eb93f5837bc5ba13f0b96c7
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Mar 4 16:57:08 2016 +0100

    -Werror,-Wnon-virtual-dtor
    
    This looks like a real bug, causing leaks in the derived VistaFilePickerImpl
    (but harmless for the derived AsyncPickerEvents).
    
    Change-Id: Ic0de3f56574b89fb45eccb09fb27b78427f712d4

diff --git a/fpicker/source/win32/filepicker/asyncrequests.hxx b/fpicker/source/win32/filepicker/asyncrequests.hxx
index f786bab..efca551 100644
--- a/fpicker/source/win32/filepicker/asyncrequests.hxx
+++ b/fpicker/source/win32/filepicker/asyncrequests.hxx
@@ -120,6 +120,7 @@ typedef std::queue< RequestRef >  RequestQueue;
 class RequestHandler
 {
     public:
+        virtual ~RequestHandler() {}
         virtual void before() = 0;
         virtual void doRequest(const RequestRef& rRequest) = 0;
         virtual void after() = 0;


More information about the Libreoffice-commits mailing list