[Libreoffice-commits] core.git: apple_remote/source
Douglas Mencken
dougmencken at gmail.com
Mon Mar 7 16:07:40 UTC 2016
apple_remote/source/RemoteMainController.m | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit d676bd620afe47a0b7a445d864bfcdd2e6e3473f
Author: Douglas Mencken <dougmencken at gmail.com>
Date: Mon Mar 7 06:23:31 2016 -0500
apple_remote: autorelease --> release in dealloc (destructor)
using autorelease here leads to “just leaking” because there's no autorelease pool for thread
besides, make sure that released fields do not contain used•to•be•a•valid•pointer value
Change-Id: Id6cb37643230f64dbe9f6128f52236f04d0c88e4
Reviewed-on: https://gerrit.libreoffice.org/22981
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
diff --git a/apple_remote/source/RemoteMainController.m b/apple_remote/source/RemoteMainController.m
index 1972c5f..79af22f 100644
--- a/apple_remote/source/RemoteMainController.m
+++ b/apple_remote/source/RemoteMainController.m
@@ -155,9 +155,9 @@
}
- (void) dealloc {
- [remoteControl autorelease];
- [remoteControlBehavior autorelease];
- [super dealloc];
+ [ remoteControl release ]; remoteControl = nil;
+ [ remoteControlBehavior release ]; remoteControlBehavior = nil;
+ [super dealloc];
}
// for bindings access
More information about the Libreoffice-commits
mailing list