[Libreoffice-commits] core.git: 2 commits - sc/qa

[Tor Lillqvist]

 sc/qa/extras/check_data_pilot_field.cxx |   11 ++++++-----
 sc/qa/extras/check_data_pilot_table.cxx |   10 +++++-----
 2 files changed, 11 insertions(+), 10 deletions(-)

New commits:
commit 1c553c98c28ed7b69a779b5ec608ccdb74ed8d34
Author: Tor Lillqvist <tml at collabora.com>
Date:   Sun Mar 20 20:03:55 2016 +0200

    loplugin:stringconstant
    
    Change-Id: I94db03d7aa812df584cc13e75c132c09ce4b33aa

diff --git a/sc/qa/extras/check_data_pilot_field.cxx b/sc/qa/extras/check_data_pilot_field.cxx
index b0e7181..3ff8c65 100644
--- a/sc/qa/extras/check_data_pilot_field.cxx
+++ b/sc/qa/extras/check_data_pilot_field.cxx
@@ -120,10 +120,10 @@ uno::Reference< uno::XInterface > CheckDataPilotField::init()
     //Filling a table
     for (int i = 1; i < mMaxFieldIndex; i++)
     {
-        oSheet->getCellByPosition(i, 0)->setFormula(OUString("Col") + OUString::number(i));
-        oSheet->getCellByPosition(0, i)->setFormula(OUString("Row") + OUString::number(i));
-        oSheet2->getCellByPosition(i, 0)->setFormula(OUString("Col") + OUString::number(i));
-        oSheet2->getCellByPosition(0, i)->setFormula(OUString("Row") + OUString::number(i));
+        oSheet->getCellByPosition(i, 0)->setFormula("Col" + OUString::number(i));
+        oSheet->getCellByPosition(0, i)->setFormula("Row" + OUString::number(i));
+        oSheet2->getCellByPosition(i, 0)->setFormula("Col" + OUString::number(i));
+        oSheet2->getCellByPosition(0, i)->setFormula("Row" + OUString::number(i));
     }
 
     for (int i = 1; i < mMaxFieldIndex; i++)
diff --git a/sc/qa/extras/check_data_pilot_table.cxx b/sc/qa/extras/check_data_pilot_table.cxx
index e870699..b5e786b 100644
--- a/sc/qa/extras/check_data_pilot_table.cxx
+++ b/sc/qa/extras/check_data_pilot_table.cxx
@@ -119,10 +119,10 @@ uno::Reference< uno::XInterface > CheckDataPilotTable::init()
     //Filling a table
     for (int i = 1; i < mMaxFieldIndex; i++)
     {
-        oSheet->getCellByPosition(i, 0)->setFormula(OUString("Col") + OUString::number(i));
-        oSheet->getCellByPosition(0, i)->setFormula(OUString("Row") + OUString::number(i));
-        oSheet2->getCellByPosition(i, 0)->setFormula(OUString("Col") + OUString::number(i));
-        oSheet2->getCellByPosition(0, i)->setFormula(OUString("Row") + OUString::number(i));
+        oSheet->getCellByPosition(i, 0)->setFormula("Col" + OUString::number(i));
+        oSheet->getCellByPosition(0, i)->setFormula("Row" + OUString::number(i));
+        oSheet2->getCellByPosition(i, 0)->setFormula("Col" + OUString::number(i));
+        oSheet2->getCellByPosition(0, i)->setFormula("Row" + OUString::number(i));
     }
 
     for (int i = 1; i < mMaxFieldIndex; i++)
commit 1ed0091c91d17f3f3cf28d41e15225bc1cb33a92
Author: Tor Lillqvist <tml at collabora.com>
Date:   Sun Mar 20 20:01:20 2016 +0200

    -Werror,-Winconsistent-missing-override
    
    Change-Id: Ic197ab65be361ae3e642da2e20da4aba5cb93a74

diff --git a/sc/qa/extras/check_data_pilot_field.cxx b/sc/qa/extras/check_data_pilot_field.cxx
index eb0b12a..b0e7181 100644
--- a/sc/qa/extras/check_data_pilot_field.cxx
+++ b/sc/qa/extras/check_data_pilot_field.cxx
@@ -41,7 +41,8 @@ class CheckDataPilotField : public CalcUnoApiTest, public apitest::XNamed, publi
     virtual void setUp() override;
     virtual void tearDown() override;
 
-    uno::Reference< uno::XInterface > init();
+    uno::Reference< uno::XInterface > init() override;
+
     CPPUNIT_TEST_SUITE(CheckDataPilotField);
 
     // _XNamed
diff --git a/sc/qa/extras/check_data_pilot_table.cxx b/sc/qa/extras/check_data_pilot_table.cxx
index 70dbbbe..e870699 100644
--- a/sc/qa/extras/check_data_pilot_table.cxx
+++ b/sc/qa/extras/check_data_pilot_table.cxx
@@ -43,7 +43,7 @@ public:
     virtual void setUp() override;
     virtual void tearDown() override;
 
-    uno::Reference< uno::XInterface > init();
+    uno::Reference< uno::XInterface > init() override;
 
     CPPUNIT_TEST_SUITE(CheckDataPilotTable);
     // _XNamed