[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - dbaccess/source

Lionel Elie Mamane lionel at mamane.lu
Thu Mar 24 10:21:14 UTC 2016


 dbaccess/source/core/api/KeySet.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cd8855b8ddf7a1c4ea13851eb9e97e95dbcdbe3b
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Mon Mar 21 16:11:45 2016 +0100

    off-by-one error: columns are numbered from one, but the array from 0
    
    Change-Id: I14ef451999fa1f9d57757a9e231fc66be4e53f3a
    Reviewed-on: https://gerrit.libreoffice.org/23405
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/dbaccess/source/core/api/KeySet.cxx b/dbaccess/source/core/api/KeySet.cxx
index 5b108c8..1e56823 100644
--- a/dbaccess/source/core/api/KeySet.cxx
+++ b/dbaccess/source/core/api/KeySet.cxx
@@ -842,7 +842,7 @@ void OKeySet::copyRowValue(const ORowSetRow& _rInsertRow,ORowSetRow& _rKeyRow,sa
     for(sal_Int32 i = 1;aParaIter != aParaEnd;++aParaIter,++aParaValuesIter,++i)
     {
         ORowSetValue aValue(*aParaValuesIter);
-        aValue.setSigned(m_aSignedFlags[aParaIter->second.nPosition]);
+        aValue.setSigned(m_aSignedFlags[aParaIter->second.nPosition-1]);
         if ( (_rInsertRow->get())[aParaIter->second.nPosition] != aValue )
         {
             rtl::Reference<ORowSetValueVector> aCopy(new ORowSetValueVector(*m_aParameterValueForCache.get()));


More information about the Libreoffice-commits mailing list