[Libreoffice-commits] core.git: sc/source

Markus Mohrhard markus.mohrhard at googlemail.com
Wed Mar 30 04:05:50 UTC 2016


 sc/source/core/data/fillinfo.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 2c69316037e29db52393d898100e6593a6cd5a24
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Wed Mar 30 02:55:18 2016 +0200

    add TODO comment for a bug
    
    This bug is the first one that was discovered because it is now much
    easier to see which parts of the code work on cells, pattern areas and
    whole columns/rows.
    
    Change-Id: I8f22bf421298947d65bfc2fc9c986d85169e6545
    Reviewed-on: https://gerrit.libreoffice.org/23636
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index 384e3ae..b32f483 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -363,6 +363,8 @@ bool handleConditionalFormat(ScConditionalFormatList* pCondFormList, const std::
                 pInfo->pConditionSet = &pStyleSheet->GetItemSet();
                 bAnyCondition = true;
 
+                // TODO: moggi: looks like there is a but around bHidden and bHideFormula
+                //              They are normally for the whole pattern and not for a single cell
                 // we need to check already here for protected cells
                 const SfxPoolItem* pItem;
                 if ( bTabProtect && pInfo->pConditionSet->GetItemState( ATTR_PROTECTION, true, &pItem ) == SfxItemState::SET )


More information about the Libreoffice-commits mailing list