[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - filter/source
David Tardon
dtardon at redhat.com
Tue May 3 15:58:25 UTC 2016
filter/source/config/cache/filtercache.cxx | 2 +-
filter/source/config/cache/filtercache.hxx | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 9b5fa0a53f5b23b3c6d53b110b8c68a2ddfdbd62
Author: David Tardon <dtardon at redhat.com>
Date: Tue May 3 14:49:34 2016 +0200
tdf#99353 take the footgun away from FilterCache
FilterCache::impl_saveItem changes the properties of a config. item
one-by-one. But it also listens to the configuration changes and reloads
the whole item from the configuration on change...
Change-Id: I9e4ed1c6b013925d07f0942717fe3421f924279d
(cherry picked from commit 390ddd3bde617388e481b6747aa7bbea17d5ddf1)
Reviewed-on: https://gerrit.libreoffice.org/24610
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>
diff --git a/filter/source/config/cache/filtercache.cxx b/filter/source/config/cache/filtercache.cxx
index dacad09..f39b67f 100644
--- a/filter/source/config/cache/filtercache.cxx
+++ b/filter/source/config/cache/filtercache.cxx
@@ -1809,7 +1809,7 @@ CacheItemList::iterator FilterCache::impl_loadItemOnDemand( EItemType
void FilterCache::impl_saveItem(const css::uno::Reference< css::container::XNameReplace >& xItem,
EItemType eType,
- const CacheItem& aItem)
+ const CacheItem aItem)
throw(css::uno::Exception)
{
CacheItem::const_iterator pIt;
diff --git a/filter/source/config/cache/filtercache.hxx b/filter/source/config/cache/filtercache.hxx
index a986849..c3db85a 100644
--- a/filter/source/config/cache/filtercache.hxx
+++ b/filter/source/config/cache/filtercache.hxx
@@ -839,7 +839,7 @@ class FilterCache : public BaseLock
/** TODO */
static void impl_saveItem(const css::uno::Reference< css::container::XNameReplace >& xSet ,
EItemType eType ,
- const CacheItem& aValue)
+ const CacheItem aValue)
throw(css::uno::Exception);
More information about the Libreoffice-commits
mailing list