[Libreoffice-commits] core.git: Branch 'libreoffice-5-1-3' - filter/source

David Tardon dtardon at redhat.com
Tue May 3 20:52:55 UTC 2016


 filter/source/config/cache/filtercache.cxx |    2 +-
 filter/source/config/cache/filtercache.hxx |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 00d2bef594998f8c5669f7070cf5a2c779c9b633
Author: David Tardon <dtardon at redhat.com>
Date:   Tue May 3 14:49:34 2016 +0200

    tdf#99353 take the footgun away from FilterCache
    
    FilterCache::impl_saveItem changes the properties of a config. item
    one-by-one. But it also listens to the configuration changes and reloads
    the whole item from the configuration on change...
    
    Change-Id: I9e4ed1c6b013925d07f0942717fe3421f924279d
    (cherry picked from commit 390ddd3bde617388e481b6747aa7bbea17d5ddf1)
    Reviewed-on: https://gerrit.libreoffice.org/24611
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice at googlemail.com>
    Tested-by: Christian Lohmaier <lohmaier+LibreOffice at googlemail.com>

diff --git a/filter/source/config/cache/filtercache.cxx b/filter/source/config/cache/filtercache.cxx
index dacad09..f39b67f 100644
--- a/filter/source/config/cache/filtercache.cxx
+++ b/filter/source/config/cache/filtercache.cxx
@@ -1809,7 +1809,7 @@ CacheItemList::iterator FilterCache::impl_loadItemOnDemand(      EItemType
 
 void FilterCache::impl_saveItem(const css::uno::Reference< css::container::XNameReplace >& xItem,
                                       EItemType                                            eType,
-                                const CacheItem&                                           aItem)
+                                const CacheItem                                            aItem)
     throw(css::uno::Exception)
 {
     CacheItem::const_iterator pIt;
diff --git a/filter/source/config/cache/filtercache.hxx b/filter/source/config/cache/filtercache.hxx
index a986849..c3db85a 100644
--- a/filter/source/config/cache/filtercache.hxx
+++ b/filter/source/config/cache/filtercache.hxx
@@ -839,7 +839,7 @@ class FilterCache : public BaseLock
         /** TODO */
         static void impl_saveItem(const css::uno::Reference< css::container::XNameReplace >& xSet  ,
                                  EItemType                                            eType ,
-                           const CacheItem&                                           aValue)
+                           const CacheItem                                           aValue)
             throw(css::uno::Exception);
 
 


More information about the Libreoffice-commits mailing list