[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp

Ashod Nakashian ashod.nakashian at collabora.co.uk
Sun May 8 04:39:25 UTC 2016


 loolwsd/ChildProcessSession.cpp |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit dd164f905f8b96efb778a965e0e4ff39c631f3ac
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Sun May 8 00:01:30 2016 -0400

    loolwsd: no need to send clients current part on invalidation
    
    Invalidation messages already contain the part they
    are referring to (with the exception of EMPTY).
    
    Sending clients the current part makes it hard
    to let clients view different parts of a doc
    while an editor types.
    
    It also implies that the part has changed,
    which isn't necessarily true. If it is, a
    separate curpart notification will be sent.
    
    Change-Id: I49afcebef8994c892ef8be633d3ce3982b031d2b
    Reviewed-on: https://gerrit.libreoffice.org/24750
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
    Tested-by: Ashod Nakashian <ashnakash at gmail.com>

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 10183ac..2a3c2e5 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -124,9 +124,9 @@ public:
                 assert(lokitDoc->pClass->getPart);
 
                 int curPart = lokitDoc->pClass->getPart(lokitDoc);
-                _session.sendTextFrame("curpart: part=" + std::to_string(curPart));
                 if (_session.getDocType() == "text")
                 {
+                    // Text docs have a single coordinate system.
                     curPart = 0;
                 }
 
@@ -134,7 +134,6 @@ public:
                 if (tokens.count() == 4)
                 {
                     int x, y, width, height;
-
                     try
                     {
                         x = std::stoi(tokens[0]);


More information about the Libreoffice-commits mailing list