[Libreoffice-commits] core.git: sc/source

Julien Nabet serval2412 at yahoo.fr
Sun May 8 16:52:47 UTC 2016


 sc/source/filter/xml/xmldrani.cxx                    |    2 --
 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx |    1 -
 sc/source/ui/cctrl/cbuttonw.cxx                      |    3 +--
 3 files changed, 1 insertion(+), 5 deletions(-)

New commits:
commit de34052e31c6cb6caefe89e52dee3039eb3fbacb
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sun May 8 17:32:04 2016 +0200

    cppcheck: fix some redundantAssignment reports
    
    Change-Id: I8e93fc0bff95c5c7a15ccecaaf19fce12e69ca6d
    Reviewed-on: https://gerrit.libreoffice.org/24765
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/sc/source/filter/xml/xmldrani.cxx b/sc/source/filter/xml/xmldrani.cxx
index 476ec86..61e154f 100644
--- a/sc/source/filter/xml/xmldrani.cxx
+++ b/sc/source/filter/xml/xmldrani.cxx
@@ -365,8 +365,6 @@ std::unique_ptr<ScDBData> ScXMLDatabaseRangeContext::ConvertToDBData(const OUStr
         aParam.bCaseSens = bSubTotalsIsCaseSensitive;
         aParam.bDoSort = bSubTotalsSortGroups;
         aParam.bAscending = bSubTotalsAscending;
-        aParam.bUserDef = bSubTotalsEnabledUserList;
-        aParam.nUserIndex = nSubTotalsUserListIndex;
         std::vector <ScSubTotalRule>::iterator itr = aSubTotalRules.begin(), itrEnd = aSubTotalRules.end();
         for (size_t nPos = 0; itr != itrEnd; ++itr, ++nPos)
         {
diff --git a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
index e7030b4..bab7391 100644
--- a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
+++ b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
@@ -1576,7 +1576,6 @@ void ScAccessibleSpreadsheet::NotifyRefMode()
         AccessibleEventObject aEvent;
         aEvent.Source = uno::Reference< XAccessible >(this);
         aEvent.EventId = AccessibleEventId::ACTIVE_DESCENDANT_CHANGED;
-        aEvent.Source = uno::Reference< XAccessible >(this);
         aEvent.OldValue <<= uno::Reference<XAccessible>(m_pAccFormulaCell.get());
         m_pAccFormulaCell = GetAccessibleCellAt(aFormulaAddr.Row(), aFormulaAddr.Col());
         uno::Reference< XAccessible > xNew = m_pAccFormulaCell.get();
diff --git a/sc/source/ui/cctrl/cbuttonw.cxx b/sc/source/ui/cctrl/cbuttonw.cxx
index 46ebb21..5a5a700 100644
--- a/sc/source/ui/cctrl/cbuttonw.cxx
+++ b/sc/source/ui/cctrl/cbuttonw.cxx
@@ -62,13 +62,12 @@ void ScDDComboBoxButton::Draw( const Point& rAt,
     bool        bOldEnable = pOut->IsMapModeEnabled();
 
     Rectangle   aBtnRect( rAt, rSize );
-    Rectangle   aInnerRect = aBtnRect;
 
     pOut->EnableMapMode( false );
 
     DecorationView aDecoView( pOut);
 
-    aInnerRect=aDecoView.DrawButton( aBtnRect, DrawButtonFlags::Default );
+    Rectangle aInnerRect=aDecoView.DrawButton( aBtnRect, DrawButtonFlags::Default );
 
     aInnerRect.Left()   += 1;
     aInnerRect.Top()    += 1;


More information about the Libreoffice-commits mailing list