[Libreoffice-commits] core.git: sfx2/source

[Stephan Bergmann]

 sfx2/source/appl/workwin.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 498d3d9c4b1b1201f1a8eaeb52cfd0dd9eaa047b
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue May 10 18:11:27 2016 +0200

    Presumably missing break in switch
    
    The code was like this ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a
    "initial import", but it looks more like the break was always missing than that
    it was an intended fallthrough.  Note how the symmetric FIRSTRIGHT case does end
    in a break.  Also note that in the original code, the fallthrough case RIGHT
    guarded its modifications with
    
      if (bTbx || n <= nPos)
          aInnerRect.Right() -= pCli->aSize.Width();
      break;
    
    (where the surrounding if got since removed), so it was presumably less likely
    that an erroneous fallthrough actually caused any modifications.
    
    Change-Id: Idf7ee117f1e22dee19343684a2f56fbf464bdb7f

diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx
index 891ddb9..462b8a5 100644
--- a/sfx2/source/appl/workwin.cxx
+++ b/sfx2/source/appl/workwin.cxx
@@ -1708,6 +1708,7 @@ void SfxWorkWindow::ConfigChild_Impl(SfxChildIdentifier eChild,
                             // Is only counted if it is the current window
                             if (i == nPos)
                                 aInnerRect.Left() += pCli->aSize.Width();
+                            break;
 
                         case SfxChildAlignment::RIGHT:
                             // Toolboxes come always last