[Libreoffice-commits] core.git: drawinglayer/source

Stephan Bergmann sbergman at redhat.com
Thu May 12 09:33:49 UTC 2016


 drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

New commits:
commit 3eaf7ae663e7dd0fded01dd73bbedda59e8a0af3
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu May 12 11:33:18 2016 +0200

    Massage code to avoid warnings
    
    Change-Id: I847e1a109bd20e64161a7735ee30b2fe1ca507b0

diff --git a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
index a924b3d..93a5f55 100644
--- a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
+++ b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
@@ -378,14 +378,11 @@ namespace drawinglayer
                     aRetval = Primitive2DContainer { aPrimitiveBlackAndWhite };
                     break;
                 }
-                // coverity[dead_error_begin] - intentional dead case
-                case GRAPHICDRAWMODE_WATERMARK:
-                {
-                    assert(false && "OOps, GRAPHICDRAWMODE_WATERMARK should already be handled (see above)");
-                    // fallthrough intended
-                }
                 default: // case GRAPHICDRAWMODE_STANDARD:
                 {
+                    assert(
+                        aGraphicDrawMode != GRAPHICDRAWMODE_WATERMARK
+                        && "OOps, GRAPHICDRAWMODE_WATERMARK should already be handled (see above)");
                     // nothing to do
                     break;
                 }


More information about the Libreoffice-commits mailing list