[Libreoffice-commits] core.git: include/ucbhelper ucb/source

Noel Grandin noel at peralex.com
Thu May 19 06:41:18 UTC 2016


 include/ucbhelper/interactionrequest.hxx         |   48 -----------------
 include/ucbhelper/interceptedinteraction.hxx     |   42 ---------------
 include/ucbhelper/registerucb.hxx                |    6 --
 ucb/source/cacher/contentresultsetwrapper.hxx    |    5 -
 ucb/source/ucp/file/shell.hxx                    |    1 
 ucb/source/ucp/ftp/ftpcontent.cxx                |    1 
 ucb/source/ucp/ftp/ftpstrcont.hxx                |   62 -----------------------
 ucb/source/ucp/ftp/ftpurl.cxx                    |    1 
 ucb/source/ucp/hierarchy/hierarchyuri.hxx        |    1 
 ucb/source/ucp/package/pkguri.hxx                |    1 
 ucb/source/ucp/tdoc/tdoc_stgelems.hxx            |    2 
 ucb/source/ucp/tdoc/tdoc_uri.hxx                 |    1 
 ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx |    1 
 13 files changed, 172 deletions(-)

New commits:
commit 239cba2b06bc7894270aa68e381cc06a9d52773c
Author: Noel Grandin <noel at peralex.com>
Date:   Wed May 18 13:24:49 2016 +0200

    loplugin:unusedmethods in ucb/ucbhelper
    
    Change-Id: I2935904e2cbecec6c928f4cbc88979bc2d1a40f8
    Reviewed-on: https://gerrit.libreoffice.org/25090
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/include/ucbhelper/interactionrequest.hxx b/include/ucbhelper/interactionrequest.hxx
index c3dbf8f..8aef29e 100644
--- a/include/ucbhelper/interactionrequest.hxx
+++ b/include/ucbhelper/interactionrequest.hxx
@@ -353,27 +353,6 @@ public:
     /**
       * Constructor.
       *
-      * @param rxRequest is the interaction request that owns this continuation.
-      * @param bCanSetRealm indicates, whether the realm given with the
-      *        authentication request is read-only.
-      * @param bCanSetUserName indicates, whether the username given with the
-      *        authentication request is read-only.
-      * @param bCanSetPassword indicates, whether the password given with the
-      *        authentication request is read-only.
-      * @param bCanSetAccount indicates, whether the account given with the
-      *        authentication request is read-only.
-      *
-      * @see css::ucb::AuthenticationRequest
-      */
-    inline InteractionSupplyAuthentication(
-                    InteractionRequest * pRequest,
-                    bool bCanSetRealm,
-                    bool bCanSetUserName,
-                    bool bCanSetPassword,
-                    bool bCanSetAccount);
-    /**
-      * Constructor.
-      *
       * Note: The remember-authentication stuff is interesting only for
       *       clients implementing own password storage functionality.
       *
@@ -527,33 +506,6 @@ public:
 };
 
 
-inline InteractionSupplyAuthentication::InteractionSupplyAuthentication(
-                    InteractionRequest * pRequest,
-                    bool bCanSetRealm,
-                    bool bCanSetUserName,
-                    bool bCanSetPassword,
-                    bool bCanSetAccount )
-: InteractionContinuation( pRequest ),
-  m_aRememberPasswordModes( css::uno::Sequence< css::ucb::RememberAuthentication >( 1 ) ),
-  m_aRememberAccountModes( css::uno::Sequence< css::ucb::RememberAuthentication >( 1 ) ),
-  m_eRememberPasswordMode( css::ucb::RememberAuthentication_NO ),
-  m_eDefaultRememberPasswordMode( css::ucb::RememberAuthentication_NO ),
-  m_eRememberAccountMode( css::ucb::RememberAuthentication_NO ),
-  m_eDefaultRememberAccountMode( css::ucb::RememberAuthentication_NO ),
-  m_bCanSetRealm( bCanSetRealm ),
-  m_bCanSetUserName( bCanSetUserName ),
-  m_bCanSetPassword( bCanSetPassword ),
-  m_bCanSetAccount( bCanSetAccount ),
-  m_bCanUseSystemCredentials( false ),
-  m_bDefaultUseSystemCredentials( false ),
-  m_bUseSystemCredentials( false )
-{
-    m_aRememberPasswordModes[ 0 ]
-        = css::ucb::RememberAuthentication_NO;
-    m_aRememberAccountModes [ 0 ]
-        = css::ucb::RememberAuthentication_NO;
-}
-
 
 inline InteractionSupplyAuthentication::InteractionSupplyAuthentication(
     InteractionRequest * pRequest,
diff --git a/include/ucbhelper/interceptedinteraction.hxx b/include/ucbhelper/interceptedinteraction.hxx
index 26e1a9a..50dae33 100644
--- a/include/ucbhelper/interceptedinteraction.hxx
+++ b/include/ucbhelper/interceptedinteraction.hxx
@@ -102,35 +102,6 @@ class UCBHELPER_DLLPUBLIC InterceptedInteraction : public ::cppu::WeakImplHelper
                 Handle     = INVALID_HANDLE;
             }
 
-
-            /** @short  initialize this instance.
-
-                @param  nHandle
-                        used to identify every intercepted request
-
-                @param  aRequest
-                        must contain an exception object, which can be checked
-                        in its uno-type against the later handled interaction.
-
-                @param  aContinuation
-                        must contain a continuation object, which is used
-                        in its uno-type to locate the same continuation
-                        inside the list of possible ones.
-
-                @param  bMatchExact
-                        influence the type check of the interception request.
-                        Its not used to check the continuation!
-             */
-            InterceptedRequest(      sal_Int32                nHandle      ,
-                               const css::uno::Any&           aRequest     ,
-                               const css::uno::Type&          aContinuation,
-                                     bool                     bMatchExact  )
-            {
-                Handle       = nHandle;
-                Request      = aRequest;
-                Continuation = aContinuation;
-                MatchExact   = bMatchExact;
-            }
         };
 
 
@@ -180,19 +151,6 @@ class UCBHELPER_DLLPUBLIC InterceptedInteraction : public ::cppu::WeakImplHelper
         InterceptedInteraction();
 
 
-        /** @short  initialize a new instance with real values.
-
-            @param  xInterceptedHandler
-                    the outside interaction handler, which should
-                    be intercepted here.
-
-            @param  lInterceptions
-                    the list of intercepted requests.
-         */
-        InterceptedInteraction(const css::uno::Reference< css::task::XInteractionHandler >& xInterceptedHandler,
-                               const ::std::vector< InterceptedRequest >&                                             lInterceptions     );
-
-
         /** @short  initialize a new instance with the interaction handler,
                     which should be intercepted.
 
diff --git a/include/ucbhelper/registerucb.hxx b/include/ucbhelper/registerucb.hxx
index 60ab221..0b60481 100644
--- a/include/ucbhelper/registerucb.hxx
+++ b/include/ucbhelper/registerucb.hxx
@@ -56,12 +56,6 @@ struct ContentProviderData
     /** The arguments to use to instanciate the content provider.
      */
     OUString Arguments;
-
-    ContentProviderData() {};
-    ContentProviderData( const OUString & rService,
-                         const OUString & rTemplate,
-                         const OUString & rArgs )
-    : ServiceName( rService ), URLTemplate( rTemplate ), Arguments( rArgs ) {}
 };
 
 typedef std::vector< ContentProviderData > ContentProviderDataList;
diff --git a/ucb/source/cacher/contentresultsetwrapper.hxx b/ucb/source/cacher/contentresultsetwrapper.hxx
index 65cdd07..fb672fc 100644
--- a/ucb/source/cacher/contentresultsetwrapper.hxx
+++ b/ucb/source/cacher/contentresultsetwrapper.hxx
@@ -57,11 +57,6 @@ protected:
         osl::Mutex* pT;
     public:
 
-        ReacquireableGuard(osl::Mutex * t) : pT(t)
-        {
-            pT->acquire();
-        }
-
         ReacquireableGuard(osl::Mutex& t) : pT(&t)
         {
             pT->acquire();
diff --git a/ucb/source/ucp/file/shell.hxx b/ucb/source/ucp/file/shell.hxx
index cf45e64..3408ad0 100644
--- a/ucb/source/ucp/file/shell.hxx
+++ b/ucb/source/ucp/file/shell.hxx
@@ -87,7 +87,6 @@ namespace fileaccess {
             css::beans::PropertyState   State;
             sal_Int16                   Attributes;
         public:
-            MyProperty();
             explicit MyProperty( const OUString&  thePropertyName );
             MyProperty( bool                              theIsNative,
                         const OUString&                   thePropertyName,
diff --git a/ucb/source/ucp/ftp/ftpcontent.cxx b/ucb/source/ucp/ftp/ftpcontent.cxx
index 42b40b0..0e1222d 100644
--- a/ucb/source/ucp/ftp/ftpcontent.cxx
+++ b/ucb/source/ucp/ftp/ftpcontent.cxx
@@ -33,7 +33,6 @@
 #include "ftpdirp.hxx"
 #include "ftpcontentidentifier.hxx"
 #include "ftpcfunc.hxx"
-#include "ftpstrcont.hxx"
 #include "ftpintreq.hxx"
 
 #include <memory>
diff --git a/ucb/source/ucp/ftp/ftpstrcont.hxx b/ucb/source/ucp/ftp/ftpstrcont.hxx
deleted file mode 100644
index 44fda8f..0000000
--- a/ucb/source/ucp/ftp/ftpstrcont.hxx
+++ /dev/null
@@ -1,62 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-/**************************************************************************
-                                TODO
- **************************************************************************
-
- *************************************************************************/
-#ifndef INCLUDED_UCB_SOURCE_UCP_FTP_FTPSTRCONT_HXX
-#define INCLUDED_UCB_SOURCE_UCP_FTP_FTPSTRCONT_HXX
-
-#include <com/sun/star/io/XInputStream.hpp>
-#include <com/sun/star/io/XOutputStream.hpp>
-#include "ftpcfunc.hxx"
-
-
-namespace ftp {
-
-    class FTPInputStream;
-
-    class FTPOutputStreamContainer
-        : public FTPStreamContainer
-    {
-    public:
-        explicit FTPOutputStreamContainer(const css::uno::Reference<
-                                 css::io::XOutputStream>& out);
-
-        virtual ~FTPOutputStreamContainer() {}
-    };
-
-
-    class FTPInputStreamContainer
-        : public FTPStreamContainer
-    {
-    public:
-        explicit FTPInputStreamContainer(FTPInputStream* out);
-
-        virtual ~FTPInputStreamContainer() {}
-    };
-
-}
-
-
-#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/ucb/source/ucp/ftp/ftpurl.cxx b/ucb/source/ucp/ftp/ftpurl.cxx
index 9f2ffce..6c33c81 100644
--- a/ucb/source/ucp/ftp/ftpurl.cxx
+++ b/ucb/source/ucp/ftp/ftpurl.cxx
@@ -33,7 +33,6 @@
 #include <string.h>
 #include <rtl/uri.hxx>
 
-#include "ftpstrcont.hxx"
 #include "ftpurl.hxx"
 #include "ftpcontentprovider.hxx"
 #include "ftpcfunc.hxx"
diff --git a/ucb/source/ucp/hierarchy/hierarchyuri.hxx b/ucb/source/ucp/hierarchy/hierarchyuri.hxx
index 24dfb05..388a305 100644
--- a/ucb/source/ucp/hierarchy/hierarchyuri.hxx
+++ b/ucb/source/ucp/hierarchy/hierarchyuri.hxx
@@ -42,7 +42,6 @@ private:
     void init() const;
 
 public:
-    HierarchyUri() : m_bValid( false ) {}
     explicit HierarchyUri( const OUString & rUri )
     : m_aUri( rUri ), m_bValid( false ) {}
 
diff --git a/ucb/source/ucp/package/pkguri.hxx b/ucb/source/ucp/package/pkguri.hxx
index b66bae0..605e539 100644
--- a/ucb/source/ucp/package/pkguri.hxx
+++ b/ucb/source/ucp/package/pkguri.hxx
@@ -45,7 +45,6 @@ private:
     void init() const;
 
 public:
-    PackageUri() : m_bValid( false ) {}
     explicit PackageUri( const OUString & rPackageUri )
     : m_aUri( rPackageUri ), m_bValid( false ) {}
 
diff --git a/ucb/source/ucp/tdoc/tdoc_stgelems.hxx b/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
index d71ccf4..10058ed 100644
--- a/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
@@ -269,8 +269,6 @@ public:
                 css::uno::RuntimeException, std::exception ) override;
 
 private:
-    explicit Storage( const rtl::Reference< Storage > & rFactory ); // n.i.
-
     rtl::Reference< StorageElementFactory >         m_xFactory;
     css::uno::Reference< css::uno::XAggregation >         m_xAggProxy;
     css::uno::Reference< css::embed::XStorage >           m_xWrappedStorage;
diff --git a/ucb/source/ucp/tdoc/tdoc_uri.hxx b/ucb/source/ucp/tdoc/tdoc_uri.hxx
index 4d1c671..10b861b 100644
--- a/ucb/source/ucp/tdoc/tdoc_uri.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_uri.hxx
@@ -46,7 +46,6 @@ private:
     void init() const;
 
 public:
-    Uri() : m_eState( UNKNOWN ) {}
     explicit Uri( const OUString & rUri )
     : m_aUri( rUri ), m_eState( UNKNOWN ) {}
 
diff --git a/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx b/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx
index 2b36a13..43392b9 100644
--- a/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx
+++ b/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx
@@ -64,7 +64,6 @@ class DAVResourceAccess
     std::vector< NeonUri > m_aRedirectURIs;
 
 public:
-    DAVResourceAccess() : m_xSessionFactory( nullptr ) {}
     DAVResourceAccess( const css::uno::Reference< css::uno::XComponentContext > & rxContext,
                        rtl::Reference< DAVSessionFactory > const & rSessionFactory,
                        const OUString & rURL );


More information about the Libreoffice-commits mailing list