[Libreoffice-commits] core.git: include/svx svx/source

Noel Grandin noel at peralex.com
Fri May 20 12:20:11 UTC 2016


 include/svx/rubydialog.hxx       |    5 ++---
 svx/source/dialog/rubydialog.cxx |    3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

New commits:
commit 2cf9772a3e06c156c7d0a79466db57ced7fe281d
Author: Noel Grandin <noel at peralex.com>
Date:   Fri May 20 14:19:40 2016 +0200

    loplugin:refcounting
    
    Change-Id: I5cb9297c44b076dfca2a37f234ba823ba217b507

diff --git a/include/svx/rubydialog.hxx b/include/svx/rubydialog.hxx
index d5414be..441ebdc 100644
--- a/include/svx/rubydialog.hxx
+++ b/include/svx/rubydialog.hxx
@@ -120,8 +120,7 @@ class SvxRubyDialog : public SfxModelessDialog
 
     bool                bModified;
 
-    css::uno::Reference<css::view::XSelectionChangeListener> xImpl;
-    SfxBindings*    pBindings;
+    SfxBindings*        pBindings;
 
     DECL_LINK_TYPED(ApplyHdl_Impl, Button*, void);
     DECL_LINK_TYPED(CloseHdl_Impl, Button*, void);
@@ -167,7 +166,7 @@ public:
     virtual void        Deactivate() override;
 
 private:
-    std::unique_ptr<SvxRubyData_Impl> pImpl;
+    css::uno::Reference<SvxRubyData_Impl> pImpl;
 };
 
 #endif // INCLUDED_SVX_RUBYDIALOG_HXX
diff --git a/svx/source/dialog/rubydialog.cxx b/svx/source/dialog/rubydialog.cxx
index 90b7e62..a4c9fb7 100644
--- a/svx/source/dialog/rubydialog.cxx
+++ b/svx/source/dialog/rubydialog.cxx
@@ -209,7 +209,6 @@ SvxRubyDialog::SvxRubyDialog(SfxBindings* pBind, SfxChildWindow* pCW, vcl::Windo
     , pBindings(pBind)
     , pImpl( new SvxRubyData_Impl )
 {
-    xImpl = pImpl.get();
     get(m_pLeftFT, "basetextft");
     get(m_pRightFT, "rubytextft");
     get(m_pAdjustLB, "adjustlb");
@@ -280,7 +279,7 @@ void SvxRubyDialog::dispose()
 {
     ClearCharStyleList();
     EventObject aEvent;
-    xImpl->disposing(aEvent);
+    pImpl->disposing(aEvent);
     m_pLeftFT.clear();
     m_pRightFT.clear();
     m_pLeft1ED.clear();


More information about the Libreoffice-commits mailing list