[Libreoffice-commits] core.git: cui/source

Xisco Fauli anistenis at gmail.com
Thu May 26 07:30:14 UTC 2016


 cui/source/options/optinet2.cxx |    3 +--
 cui/source/options/optinet2.hxx |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 039c1043ca5d650a38a35c51988512e62a1591d2
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Mon May 23 02:04:32 2016 +0200

    tdf#89329: use unique_ptr for pImpl in optinet2
    
    Change-Id: I3f23ed564a10a9e6b0884fa1ad109d4d81ad1b6c
    Reviewed-on: https://gerrit.libreoffice.org/25332
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx
index 2dc815a..2b9d744 100644
--- a/cui/source/options/optinet2.cxx
+++ b/cui/source/options/optinet2.cxx
@@ -960,8 +960,7 @@ SvxEMailTabPage::~SvxEMailTabPage()
 
 void SvxEMailTabPage::dispose()
 {
-    delete pImpl;
-    pImpl = nullptr;
+    pImpl.reset();
     m_pMailContainer.clear();
     m_pMailerURLFI.clear();
     m_pMailerURLED.clear();
diff --git a/cui/source/options/optinet2.hxx b/cui/source/options/optinet2.hxx
index a34eccc..8f0e747 100644
--- a/cui/source/options/optinet2.hxx
+++ b/cui/source/options/optinet2.hxx
@@ -171,7 +171,7 @@ class SvxEMailTabPage : public SfxTabPage
 
     OUString      m_sDefaultFilterName;
 
-    SvxEMailTabPage_Impl* pImpl;
+    std::unique_ptr<SvxEMailTabPage_Impl> pImpl;
 
     DECL_LINK_TYPED(  FileDialogHdl_Impl, Button*, void );
 


More information about the Libreoffice-commits mailing list