[Libreoffice-commits] core.git: cui/source

Xisco Fauli anistenis at gmail.com
Thu May 26 07:31:45 UTC 2016


 cui/source/inc/optasian.hxx     |    2 +-
 cui/source/options/optasian.cxx |    3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit d0e5ed941a7e7b35ccb557ab243fc78d399c3ed5
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Mon May 23 02:00:17 2016 +0200

    tdf#89329: use unique_ptr for pImpl in optasian
    
    Change-Id: Iaa97d318b8e6b327edd6eecc6a591c55082f7531
    Reviewed-on: https://gerrit.libreoffice.org/25330
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/cui/source/inc/optasian.hxx b/cui/source/inc/optasian.hxx
index d3cb614..5507b26 100644
--- a/cui/source/inc/optasian.hxx
+++ b/cui/source/inc/optasian.hxx
@@ -46,7 +46,7 @@ class SvxAsianLayoutPage : public SfxTabPage
     VclPtr<Edit>        m_pEndED;
     VclPtr<FixedText>   m_pHintFT;
 
-    SvxAsianLayoutPage_Impl* pImpl;
+    std::unique_ptr<SvxAsianLayoutPage_Impl> pImpl;
 
     DECL_LINK_TYPED(LanguageHdl, ListBox&, void);
     DECL_LINK_TYPED(ChangeStandardHdl, Button*, void);
diff --git a/cui/source/options/optasian.cxx b/cui/source/options/optasian.cxx
index 2b0b33e..8113013 100644
--- a/cui/source/options/optasian.cxx
+++ b/cui/source/options/optasian.cxx
@@ -156,8 +156,7 @@ SvxAsianLayoutPage::~SvxAsianLayoutPage()
 
 void SvxAsianLayoutPage::dispose()
 {
-    delete pImpl;
-    pImpl = nullptr;
+    pImpl.reset();
     m_pCharKerningRB.clear();
     m_pCharPunctKerningRB.clear();
     m_pNoCompressionRB.clear();


More information about the Libreoffice-commits mailing list