[Libreoffice-commits] core.git: opencl/source sc/source sd/source sfx2/source svx/source

Caolán McNamara caolanm at redhat.com
Thu May 26 11:32:59 UTC 2016


 opencl/source/opencl_device.cxx                  |    2 +-
 sc/source/ui/inc/docsh.hxx                       |   16 ++++++++--------
 sd/source/ui/view/viewshel.cxx                   |    2 +-
 sfx2/source/view/classificationcontroller.cxx    |    2 +-
 svx/source/sidebar/text/TextUnderlineControl.hxx |    2 +-
 5 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 3c65f07ede73105cca4b1b9597d6f8b02f226db9
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu May 26 11:58:25 2016 +0100

    cppcheck: noExplicitConstructor
    
    Change-Id: Ibb6bc9a17418a8fb0b5f882285088a5b80fd5beb

diff --git a/opencl/source/opencl_device.cxx b/opencl/source/opencl_device.cxx
index db143e3..bfe81b5 100644
--- a/opencl/source/opencl_device.cxx
+++ b/opencl/source/opencl_device.cxx
@@ -465,7 +465,7 @@ class LogWriter
 private:
     SvFileStream maStream;
 public:
-    LogWriter(OUString aFileName)
+    explicit LogWriter(OUString aFileName)
         : maStream(aFileName, StreamMode::WRITE)
     {}
 
diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx
index 079b542..dcb4f9e 100644
--- a/sc/source/ui/inc/docsh.hxx
+++ b/sc/source/ui/inc/docsh.hxx
@@ -168,7 +168,7 @@ private:
     static void InitInterface_Impl();
 
 public:
-                    ScDocShell( const ScDocShell& rDocShell );
+    explicit        ScDocShell( const ScDocShell& rDocShell );
                     ScDocShell( const SfxModelFlags i_nSfxCreationFlags = SfxModelFlags::EMBEDDED_OBJECT );
                     virtual ~ScDocShell();
 
@@ -448,18 +448,18 @@ typedef tools::SvRef<ScDocShell> ScDocShellRef;
  */
 class SC_DLLPUBLIC ScDocShellModificator
 {
-            ScDocShell&     rDocShell;
+    ScDocShell&     rDocShell;
     std::unique_ptr<ScRefreshTimerProtector> mpProtector;
-            bool            bAutoCalcShellDisabled;
-            bool            bIdleEnabled;
+    bool            bAutoCalcShellDisabled;
+    bool            bIdleEnabled;
 
-                            ScDocShellModificator( const ScDocShellModificator& ) = delete;
+    ScDocShellModificator( const ScDocShellModificator& ) = delete;
     ScDocShellModificator&  operator=( const ScDocShellModificator& ) = delete;
 
 public:
-                            ScDocShellModificator( ScDocShell& );
-                            ~ScDocShellModificator();
-            void            SetDocumentModified();
+    explicit ScDocShellModificator( ScDocShell& );
+    ~ScDocShellModificator();
+    void            SetDocumentModified();
 };
 
 //#i97876# Spreadsheet data changes are not notified
diff --git a/sd/source/ui/view/viewshel.cxx b/sd/source/ui/view/viewshel.cxx
index c46b9ef..f76536b 100644
--- a/sd/source/ui/view/viewshel.cxx
+++ b/sd/source/ui/view/viewshel.cxx
@@ -1240,7 +1240,7 @@ class KeepSlideSorterInSyncWithPageChanges
     sd::slidesorter::controller::SelectionObserver::Context m_aContext;
 
 public:
-    KeepSlideSorterInSyncWithPageChanges(sd::slidesorter::SlideSorter& rSlideSorter)
+    explicit KeepSlideSorterInSyncWithPageChanges(sd::slidesorter::SlideSorter& rSlideSorter)
         : m_aDrawLock(rSlideSorter)
         , m_aModelLock(rSlideSorter.GetController())
         , m_aUpdateLock(rSlideSorter)
diff --git a/sfx2/source/view/classificationcontroller.cxx b/sfx2/source/view/classificationcontroller.cxx
index 1e932c8..caa6ef4 100644
--- a/sfx2/source/view/classificationcontroller.cxx
+++ b/sfx2/source/view/classificationcontroller.cxx
@@ -90,7 +90,7 @@ class SAL_WARN_UNUSED ClassificationControl : public vcl::Window
     virtual void DataChanged(const DataChangedEvent& rEvent) override;
 
 public:
-    ClassificationControl(vcl::Window* pParent);
+    explicit ClassificationControl(vcl::Window* pParent);
     virtual ~ClassificationControl();
     virtual void dispose() override;
     virtual void Resize() override;
diff --git a/svx/source/sidebar/text/TextUnderlineControl.hxx b/svx/source/sidebar/text/TextUnderlineControl.hxx
index a28a212..333f039 100644
--- a/svx/source/sidebar/text/TextUnderlineControl.hxx
+++ b/svx/source/sidebar/text/TextUnderlineControl.hxx
@@ -32,7 +32,7 @@ namespace svx {
 class TextUnderlineControl : public SfxPopupWindow
 {
 public:
-    TextUnderlineControl(sal_uInt16 nId);
+    explicit TextUnderlineControl(sal_uInt16 nId);
     virtual ~TextUnderlineControl();
     virtual void dispose() override;
 


More information about the Libreoffice-commits mailing list