[Libreoffice-commits] core.git: cui/source dbaccess/source extensions/source fpicker/source lotuswordpro/source package/source sc/source sdext/source sd/source sfx2/source shell/source svtools/source sw/source xmlsecurity/source
Jochen Nitschke
j.nitschke+logerrit at ok.de
Tue Nov 1 18:44:45 UTC 2016
cui/source/options/connpoolsettings.hxx | 2 +-
dbaccess/source/ui/tabledesign/TEditControl.hxx | 2 +-
extensions/source/bibliography/bibcont.hxx | 2 +-
extensions/source/propctrlr/browserlistbox.hxx | 2 +-
extensions/source/propctrlr/propertyeditor.hxx | 2 +-
extensions/source/propctrlr/usercontrol.hxx | 6 +++---
fpicker/source/win32/filepicker/comptr.hxx | 4 ++--
lotuswordpro/source/filter/explode.hxx | 2 +-
package/source/xstor/ohierarchyholder.hxx | 2 +-
sc/source/core/data/documentimport.cxx | 2 +-
sc/source/core/tool/bulkdatahint.cxx | 2 +-
sc/source/filter/xml/XMLTableShapeImportHelper.hxx | 2 +-
sc/source/ui/sidebar/CellBorderStyleControl.hxx | 2 +-
sc/source/ui/sidebar/CellLineStyleControl.hxx | 2 +-
sc/source/ui/sidebar/CellLineStyleValueSet.hxx | 2 +-
sd/source/ui/inc/optsitem.hxx | 4 ++--
sd/source/ui/unoidl/unocpres.hxx | 2 +-
sd/source/ui/view/ViewShellManager.cxx | 2 +-
sdext/source/minimizer/configurationaccess.hxx | 2 +-
sfx2/source/dialog/dockwin.cxx | 2 +-
sfx2/source/notebookbar/BigToolBox.hxx | 2 +-
sfx2/source/notebookbar/NotebookbarToolBox.cxx | 2 +-
shell/source/unix/sysshell/recently_used_file_handler.cxx | 2 +-
svtools/source/control/scriptedtext.cxx | 2 +-
svtools/source/control/toolbarmenuimp.hxx | 2 +-
sw/source/filter/xml/xmlimpit.hxx | 2 +-
sw/source/uibase/sidebar/PageMarginControl.hxx | 2 +-
xmlsecurity/source/pdfio/pdfdocument.cxx | 8 ++++----
28 files changed, 35 insertions(+), 35 deletions(-)
New commits:
commit 8826771e8398063018935c38039c05faf4c993a3
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date: Tue Nov 1 11:44:15 2016 +0100
style fixes for cppcheck noExplicitConstructor
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34
Reviewed-on: https://gerrit.libreoffice.org/30460
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit at ok.de>
diff --git a/cui/source/options/connpoolsettings.hxx b/cui/source/options/connpoolsettings.hxx
index 07b6077..7ef6bc7 100644
--- a/cui/source/options/connpoolsettings.hxx
+++ b/cui/source/options/connpoolsettings.hxx
@@ -37,7 +37,7 @@ namespace offapp
bool bEnabled;
sal_Int32 nTimeoutSeconds;
- DriverPooling( const OUString& _rName );
+ explicit DriverPooling( const OUString& _rName );
bool operator == (const DriverPooling& _rR) const;
bool operator != (const DriverPooling& _rR) const { return !operator ==(_rR); }
diff --git a/dbaccess/source/ui/tabledesign/TEditControl.hxx b/dbaccess/source/ui/tabledesign/TEditControl.hxx
index 19efd28..0c6a44d 100644
--- a/dbaccess/source/ui/tabledesign/TEditControl.hxx
+++ b/dbaccess/source/ui/tabledesign/TEditControl.hxx
@@ -73,7 +73,7 @@ namespace dbaui
VclPtr<OTableEditorCtrl> m_pOwner;
public:
- ClipboardInvalidator(OTableEditorCtrl*);
+ explicit ClipboardInvalidator(OTableEditorCtrl*);
~ClipboardInvalidator();
void Stop();
diff --git a/extensions/source/bibliography/bibcont.hxx b/extensions/source/bibliography/bibcont.hxx
index f854753..028cfff 100644
--- a/extensions/source/bibliography/bibcont.hxx
+++ b/extensions/source/bibliography/bibcont.hxx
@@ -82,7 +82,7 @@ class BibBookContainer: public BibSplitWindow
public:
- BibBookContainer(vcl::Window* pParent );
+ explicit BibBookContainer(vcl::Window* pParent );
virtual ~BibBookContainer() override;
virtual void dispose() override;
diff --git a/extensions/source/propctrlr/browserlistbox.hxx b/extensions/source/propctrlr/browserlistbox.hxx
index 07f2d48..21710f2 100644
--- a/extensions/source/propctrlr/browserlistbox.hxx
+++ b/extensions/source/propctrlr/browserlistbox.hxx
@@ -102,7 +102,7 @@ namespace pcr
void Resize() override;
public:
- OBrowserListBox( vcl::Window* pParent );
+ explicit OBrowserListBox( vcl::Window* pParent );
virtual ~OBrowserListBox() override;
virtual void dispose() override;
diff --git a/extensions/source/propctrlr/propertyeditor.hxx b/extensions/source/propctrlr/propertyeditor.hxx
index 03be07a..a40c312 100644
--- a/extensions/source/propctrlr/propertyeditor.hxx
+++ b/extensions/source/propctrlr/propertyeditor.hxx
@@ -69,7 +69,7 @@ namespace pcr
void GetFocus() override;
public:
- OPropertyEditor (vcl::Window* pParent);
+ explicit OPropertyEditor (vcl::Window* pParent);
virtual ~OPropertyEditor() override;
virtual void dispose() override;
diff --git a/extensions/source/propctrlr/usercontrol.hxx b/extensions/source/propctrlr/usercontrol.hxx
index d458764..4a5719a 100644
--- a/extensions/source/propctrlr/usercontrol.hxx
+++ b/extensions/source/propctrlr/usercontrol.hxx
@@ -59,7 +59,7 @@ namespace pcr
class OFormatSampleControl : public OFormatSampleControl_Base
{
public:
- OFormatSampleControl( vcl::Window* pParent );
+ explicit OFormatSampleControl( vcl::Window* pParent );
// XPropertyControl
virtual css::uno::Any SAL_CALL getValue() throw (css::uno::RuntimeException, std::exception) override;
@@ -128,7 +128,7 @@ namespace pcr
class OFileUrlControl : public OFileUrlControl_Base
{
public:
- OFileUrlControl( vcl::Window* pParent );
+ explicit OFileUrlControl( vcl::Window* pParent );
// XPropertyControl
virtual css::uno::Any SAL_CALL getValue() throw (css::uno::RuntimeException, std::exception) override;
@@ -145,7 +145,7 @@ namespace pcr
class OTimeDurationControl : public ONumericControl
{
public:
- OTimeDurationControl( vcl::Window* pParent );
+ explicit OTimeDurationControl( vcl::Window* pParent );
virtual ~OTimeDurationControl() override;
// XPropertyControl
diff --git a/fpicker/source/win32/filepicker/comptr.hxx b/fpicker/source/win32/filepicker/comptr.hxx
index 5cc4f4d..89fc85b 100644
--- a/fpicker/source/win32/filepicker/comptr.hxx
+++ b/fpicker/source/win32/filepicker/comptr.hxx
@@ -42,7 +42,7 @@ class ComPtr
/** initialize com ptr with given interface.
*/
- ComPtr(T_INTERFACE* pInterface)
+ explicit ComPtr(T_INTERFACE* pInterface)
{
m_pInterface = pInterface;
if (m_pInterface)
@@ -62,7 +62,7 @@ class ComPtr
/** initialize object by quering external object for the right interface.
*/
- ComPtr(IUnknown* pIUnknown)
+ explicit ComPtr(IUnknown* pIUnknown)
{
if (pIUnknown)
pIUnknown->QueryInterface(P_IID, (void**)&m_pInterface);
diff --git a/lotuswordpro/source/filter/explode.hxx b/lotuswordpro/source/filter/explode.hxx
index 27fc427..013bb6b 100644
--- a/lotuswordpro/source/filter/explode.hxx
+++ b/lotuswordpro/source/filter/explode.hxx
@@ -67,7 +67,7 @@ public:
HuffmanTreeNode * right;
sal_uInt32 value;
- HuffmanTreeNode(sal_uInt32 value = 0xffffffff) ;
+ explicit HuffmanTreeNode(sal_uInt32 value = 0xffffffff) ;
~HuffmanTreeNode() ;
HuffmanTreeNode * InsertNode(sal_uInt32 nValue, const sal_Char * pInCode);
HuffmanTreeNode * QueryNode(const sal_Char *pCode);
diff --git a/package/source/xstor/ohierarchyholder.hxx b/package/source/xstor/ohierarchyholder.hxx
index e8ae40d..4887d49 100644
--- a/package/source/xstor/ohierarchyholder.hxx
+++ b/package/source/xstor/ohierarchyholder.hxx
@@ -65,7 +65,7 @@ struct OHierarchyElement_Impl : public cppu::WeakImplHelper< css::embed::XTransa
OWeakStorRefList_Impl m_aOpenStreams;
public:
- OHierarchyElement_Impl( const css::uno::Reference< css::embed::XStorage >& xStorage )
+ explicit OHierarchyElement_Impl( const css::uno::Reference< css::embed::XStorage >& xStorage )
: m_rParent( nullptr )
, m_xOwnStorage( xStorage )
{}
diff --git a/sc/source/core/data/documentimport.cxx b/sc/source/core/data/documentimport.cxx
index d8ebcfe..69f66cd 100644
--- a/sc/source/core/data/documentimport.cxx
+++ b/sc/source/core/data/documentimport.cxx
@@ -500,7 +500,7 @@ class CellStoreInitializer
sc::CellTextAttrStoreType::iterator miPos;
SvtScriptType mnScriptNumeric;
- Impl(const SvtScriptType nScriptNumeric)
+ explicit Impl(const SvtScriptType nScriptNumeric)
: maAttrs(MAXROWCOUNT), miPos(maAttrs.begin()), mnScriptNumeric(nScriptNumeric)
{}
};
diff --git a/sc/source/core/tool/bulkdatahint.cxx b/sc/source/core/tool/bulkdatahint.cxx
index bdd0215..506942a 100644
--- a/sc/source/core/tool/bulkdatahint.cxx
+++ b/sc/source/core/tool/bulkdatahint.cxx
@@ -16,7 +16,7 @@ struct BulkDataHint::Impl
ScDocument& mrDoc;
const ColumnSpanSet* mpSpans;
- Impl( ScDocument& rDoc ) :
+ explicit Impl( ScDocument& rDoc ) :
mrDoc(rDoc),
mpSpans(nullptr) {}
};
diff --git a/sc/source/filter/xml/XMLTableShapeImportHelper.hxx b/sc/source/filter/xml/XMLTableShapeImportHelper.hxx
index ceadd12..1bb7d70 100644
--- a/sc/source/filter/xml/XMLTableShapeImportHelper.hxx
+++ b/sc/source/filter/xml/XMLTableShapeImportHelper.hxx
@@ -34,7 +34,7 @@ class XMLTableShapeImportHelper : public XMLShapeImportHelper
public:
- XMLTableShapeImportHelper( ScXMLImport& rImp );
+ explicit XMLTableShapeImportHelper( ScXMLImport& rImp );
virtual ~XMLTableShapeImportHelper() override;
static void SetLayer(css::uno::Reference<css::drawing::XShape>& rShape, sal_Int16 nLayerID, const OUString& sType);
diff --git a/sc/source/ui/sidebar/CellBorderStyleControl.hxx b/sc/source/ui/sidebar/CellBorderStyleControl.hxx
index 28c5c16..a288f1a3 100644
--- a/sc/source/ui/sidebar/CellBorderStyleControl.hxx
+++ b/sc/source/ui/sidebar/CellBorderStyleControl.hxx
@@ -43,7 +43,7 @@ private:
DECL_LINK(TB3SelectHdl, ToolBox *, void);
public:
- CellBorderStylePopup(SfxDispatcher* pDispatcher);
+ explicit CellBorderStylePopup(SfxDispatcher* pDispatcher);
virtual ~CellBorderStylePopup() override;
virtual void dispose() override;
};
diff --git a/sc/source/ui/sidebar/CellLineStyleControl.hxx b/sc/source/ui/sidebar/CellLineStyleControl.hxx
index ea5f090..399ff9a 100644
--- a/sc/source/ui/sidebar/CellLineStyleControl.hxx
+++ b/sc/source/ui/sidebar/CellLineStyleControl.hxx
@@ -44,7 +44,7 @@ class CellLineStylePopup : public FloatingWindow
public:
- CellLineStylePopup(SfxDispatcher* pDispatcher);
+ explicit CellLineStylePopup(SfxDispatcher* pDispatcher);
void SetLineStyleSelect(sal_uInt16 out, sal_uInt16 in, sal_uInt16 dis);
virtual ~CellLineStylePopup() override;
virtual void dispose() override;
diff --git a/sc/source/ui/sidebar/CellLineStyleValueSet.hxx b/sc/source/ui/sidebar/CellLineStyleValueSet.hxx
index 3e87b31..edc3c8a 100644
--- a/sc/source/ui/sidebar/CellLineStyleValueSet.hxx
+++ b/sc/source/ui/sidebar/CellLineStyleValueSet.hxx
@@ -33,7 +33,7 @@ private:
sal_uInt16 nSelItem;
OUString maStrUnit[CELL_LINE_STYLE_ENTRIES];
public:
- CellLineStyleValueSet(vcl::Window* pParent);
+ explicit CellLineStyleValueSet(vcl::Window* pParent);
virtual ~CellLineStyleValueSet() override;
virtual void dispose() override;
diff --git a/sd/source/ui/inc/optsitem.hxx b/sd/source/ui/inc/optsitem.hxx
index cde1ed3..200415a 100644
--- a/sd/source/ui/inc/optsitem.hxx
+++ b/sd/source/ui/inc/optsitem.hxx
@@ -469,7 +469,7 @@ class SdOptionsGridItem : public SvxGridItem
{
public:
- SdOptionsGridItem( SdOptions* pOpts );
+ explicit SdOptionsGridItem( SdOptions* pOpts );
void SetOptions( SdOptions* pOpts ) const;
};
@@ -563,7 +563,7 @@ class SD_DLLPUBLIC SdOptionsPrintItem : public SfxPoolItem
public:
explicit SdOptionsPrintItem();
- SdOptionsPrintItem( SdOptions* pOpts );
+ explicit SdOptionsPrintItem( SdOptions* pOpts );
virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const override;
virtual bool operator==( const SfxPoolItem& ) const override;
diff --git a/sd/source/ui/unoidl/unocpres.hxx b/sd/source/ui/unoidl/unocpres.hxx
index 493c5dd..c04ebb7 100644
--- a/sd/source/ui/unoidl/unocpres.hxx
+++ b/sd/source/ui/unoidl/unocpres.hxx
@@ -50,7 +50,7 @@ private:
public:
SdXCustomPresentation() throw();
- SdXCustomPresentation( SdCustomShow* mpSdCustomShow) throw();
+ explicit SdXCustomPresentation( SdCustomShow* mpSdCustomShow ) throw();
virtual ~SdXCustomPresentation() throw() override;
// internal
diff --git a/sd/source/ui/view/ViewShellManager.cxx b/sd/source/ui/view/ViewShellManager.cxx
index a95e27d..1d11b14 100644
--- a/sd/source/ui/view/ViewShellManager.cxx
+++ b/sd/source/ui/view/ViewShellManager.cxx
@@ -55,7 +55,7 @@ public:
bool mbIsListenerAddedToWindow;
ShellDescriptor ();
- ShellDescriptor (ShellId nId);
+ explicit ShellDescriptor (ShellId nId);
ShellDescriptor (const ShellDescriptor& rDescriptor);
ShellDescriptor& operator= (const ShellDescriptor& rDescriptor);
bool IsMainViewShell() const;
diff --git a/sdext/source/minimizer/configurationaccess.hxx b/sdext/source/minimizer/configurationaccess.hxx
index 72bc103..3a23d22 100644
--- a/sdext/source/minimizer/configurationaccess.hxx
+++ b/sdext/source/minimizer/configurationaccess.hxx
@@ -80,7 +80,7 @@ class ConfigurationAccess
{
public:
- ConfigurationAccess( const css::uno::Reference< css::uno::XComponentContext >& rXFactory );
+ explicit ConfigurationAccess( const css::uno::Reference< css::uno::XComponentContext >& rXFactory );
~ConfigurationAccess();
void SaveConfiguration();
diff --git a/sfx2/source/dialog/dockwin.cxx b/sfx2/source/dialog/dockwin.cxx
index 183600a..76c41d2 100644
--- a/sfx2/source/dialog/dockwin.cxx
+++ b/sfx2/source/dialog/dockwin.cxx
@@ -406,7 +406,7 @@ friend class SfxDockingWindow;
bool bDockingPrevented;
OString aWinState;
- SfxDockingWindow_Impl(SfxDockingWindow *pBase);
+ explicit SfxDockingWindow_Impl(SfxDockingWindow *pBase);
SfxChildAlignment GetLastAlignment() const
{ return eLastAlignment; }
void SetLastAlignment(SfxChildAlignment eAlign)
diff --git a/sfx2/source/notebookbar/BigToolBox.hxx b/sfx2/source/notebookbar/BigToolBox.hxx
index 4e31943..69d2375 100644
--- a/sfx2/source/notebookbar/BigToolBox.hxx
+++ b/sfx2/source/notebookbar/BigToolBox.hxx
@@ -37,7 +37,7 @@ namespace sfx2 { namespace notebookbar {
class SFX2_DLLPUBLIC BigToolBox : public sfx2::sidebar::SidebarToolBox
{
public:
- BigToolBox(vcl::Window* pParent);
+ explicit BigToolBox(vcl::Window* pParent);
};
diff --git a/sfx2/source/notebookbar/NotebookbarToolBox.cxx b/sfx2/source/notebookbar/NotebookbarToolBox.cxx
index 0822343..99dc666 100644
--- a/sfx2/source/notebookbar/NotebookbarToolBox.cxx
+++ b/sfx2/source/notebookbar/NotebookbarToolBox.cxx
@@ -27,7 +27,7 @@ class NotebookbarToolBox : public sfx2::sidebar::SidebarToolBox
{
public:
- NotebookbarToolBox(vcl::Window* pParentWindow)
+ explicit NotebookbarToolBox(vcl::Window* pParentWindow)
: sfx2::sidebar::SidebarToolBox(pParentWindow)
{
ToolBoxButtonSize eSize = ToolBoxButtonSize::Small;
diff --git a/shell/source/unix/sysshell/recently_used_file_handler.cxx b/shell/source/unix/sysshell/recently_used_file_handler.cxx
index d2393bf..0d2aead 100644
--- a/shell/source/unix/sysshell/recently_used_file_handler.cxx
+++ b/shell/source/unix/sysshell/recently_used_file_handler.cxx
@@ -305,7 +305,7 @@ namespace /* private */ {
class recent_item_writer
{
public:
- recent_item_writer( recently_used_file& file ) :
+ explicit recent_item_writer( recently_used_file& file ) :
file_(file),
items_written_(0)
{}
diff --git a/svtools/source/control/scriptedtext.cxx b/svtools/source/control/scriptedtext.cxx
index c6a709d..c0e26ab 100644
--- a/svtools/source/control/scriptedtext.cxx
+++ b/svtools/source/control/scriptedtext.cxx
@@ -64,7 +64,7 @@ private:
public:
/** This constructor sets an output device and fonts for all script types. */
- SvtScriptedTextHelper_Impl(
+ explicit SvtScriptedTextHelper_Impl(
OutputDevice& _rOutDevice );
/** Copy constructor. */
SvtScriptedTextHelper_Impl(
diff --git a/svtools/source/control/toolbarmenuimp.hxx b/svtools/source/control/toolbarmenuimp.hxx
index af4ac49..7ad29ac 100644
--- a/svtools/source/control/toolbarmenuimp.hxx
+++ b/svtools/source/control/toolbarmenuimp.hxx
@@ -254,7 +254,7 @@ struct ToolbarMenu_Impl
Link<ToolbarMenu*,void> maSelectHdl;
- ToolbarMenu_Impl( ToolbarMenu& rMenu );
+ explicit ToolbarMenu_Impl( ToolbarMenu& rMenu );
~ToolbarMenu_Impl();
void setAccessible( ToolbarMenuAcc* pAccessible );
diff --git a/sw/source/filter/xml/xmlimpit.hxx b/sw/source/filter/xml/xmlimpit.hxx
index d0be90e..91bbfaa 100644
--- a/sw/source/filter/xml/xmlimpit.hxx
+++ b/sw/source/filter/xml/xmlimpit.hxx
@@ -38,7 +38,7 @@ protected:
sal_uInt16 nUnknownWhich;
public:
- SvXMLImportItemMapper( SvXMLItemMapEntriesRef const & rMapEntries );
+ explicit SvXMLImportItemMapper( SvXMLItemMapEntriesRef const & rMapEntries );
virtual ~SvXMLImportItemMapper();
/** fills the given itemset with the attributes in the given list */
diff --git a/sw/source/uibase/sidebar/PageMarginControl.hxx b/sw/source/uibase/sidebar/PageMarginControl.hxx
index 050495d..6482097 100644
--- a/sw/source/uibase/sidebar/PageMarginControl.hxx
+++ b/sw/source/uibase/sidebar/PageMarginControl.hxx
@@ -44,7 +44,7 @@ namespace sw { namespace sidebar {
class PageMarginControl : public SfxPopupWindow
{
public:
- PageMarginControl( sal_uInt16 nId );
+ explicit PageMarginControl( sal_uInt16 nId );
virtual ~PageMarginControl() override;
virtual void dispose() override;
diff --git a/xmlsecurity/source/pdfio/pdfdocument.cxx b/xmlsecurity/source/pdfio/pdfdocument.cxx
index 2125749..b690b5d 100644
--- a/xmlsecurity/source/pdfio/pdfdocument.cxx
+++ b/xmlsecurity/source/pdfio/pdfdocument.cxx
@@ -54,7 +54,7 @@ class PDFCommentElement : public PDFElement
OString m_aComment;
public:
- PDFCommentElement(PDFDocument& rDoc);
+ explicit PDFCommentElement(PDFDocument& rDoc);
bool Read(SvStream& rStream) override;
};
@@ -187,7 +187,7 @@ class PDFStreamElement : public PDFElement
sal_uInt64 m_nOffset;
public:
- PDFStreamElement(size_t nLength);
+ explicit PDFStreamElement(size_t nLength);
bool Read(SvStream& rStream) override;
sal_uInt64 GetOffset() const;
};
@@ -234,7 +234,7 @@ public:
class PDFBooleanElement : public PDFElement
{
public:
- PDFBooleanElement(bool bValue);
+ explicit PDFBooleanElement(bool bValue);
bool Read(SvStream& rStream) override;
};
@@ -270,7 +270,7 @@ class PDFTrailerElement : public PDFElement
std::map<OString, PDFElement*> m_aDictionary;
public:
- PDFTrailerElement(PDFDocument& rDoc);
+ explicit PDFTrailerElement(PDFDocument& rDoc);
bool Read(SvStream& rStream) override;
PDFElement* Lookup(const OString& rDictionaryKey);
};
More information about the Libreoffice-commits
mailing list