[Libreoffice-commits] core.git: xmlsecurity/source

Tor Lillqvist tml at collabora.com
Thu Nov 3 12:01:34 UTC 2016


 xmlsecurity/source/helper/xmlsignaturehelper.cxx |   15 ---------------
 1 file changed, 15 deletions(-)

New commits:
commit c2cdf08171a84a2897dcfeee22667d2e18b48b3d
Author: Tor Lillqvist <tml at collabora.com>
Date:   Thu Nov 3 13:52:18 2016 +0200

    Bin some useless comments
    
    No need to have a comment saying 'write signatures' when calling a
    function that is called WriteSignature(). (Actually, the function name
    is slightly misleading, as it says 'signature' in singular while what
    it actually does is write multiple signatures, if present.)
    
    Also drop some leftover comments that were related to code that was
    commented out already in 2004 or 2007 and removed completely in 2010.
    
    Change-Id: I7a53b3eabb81fc03c66e746f78267be4c1751b0f

diff --git a/xmlsecurity/source/helper/xmlsignaturehelper.cxx b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
index 08ac25f..7267e5f 100644
--- a/xmlsecurity/source/helper/xmlsignaturehelper.cxx
+++ b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
@@ -225,26 +225,11 @@ bool XMLSignatureHelper::CreateAndWriteSignature( const uno::Reference< xml::sax
 {
     mbError = false;
 
-    /*
-     * create a signature listener
-     */
-
-    /*
-     * configure the signature creation listener
-     */
-
-    /*
-     * write signatures
-     */
     if ( !mpXSecController->WriteSignature( xDocumentHandler ) )
     {
         mbError = true;
     }
 
-    /*
-     * clear up the signature creation listener
-     */
-
     return !mbError;
 }
 


More information about the Libreoffice-commits mailing list