[Libreoffice-commits] core.git: sc/source

[Caolán McNamara]

 sc/source/core/tool/chgtrack.cxx |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

New commits:
commit 6aa8e86f3a80b7cbfb81500a6bb5cfeaca97791b
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 8 09:10:36 2016 +0000

    try and auto-silence coverity#1394273 Use after free
    
    and
    
    coverity#1394272 Use after free
    
    Change-Id: Id2340bccc6fbaeb917cb397890875bd0849ffe85

diff --git a/sc/source/core/tool/chgtrack.cxx b/sc/source/core/tool/chgtrack.cxx
index c39fdfe..81892b2 100644
--- a/sc/source/core/tool/chgtrack.cxx
+++ b/sc/source/core/tool/chgtrack.cxx
@@ -284,13 +284,19 @@ bool ScChangeAction::IsMasterDelete() const
 
 void ScChangeAction::RemoveAllLinks()
 {
-    while ( pLinkAny )
-        delete pLinkAny; // Moves up by itself
+    while (pLinkAny)
+    {
+        // coverity[use_after_free] - Moves up by itself
+        delete pLinkAny;
+    }
 
     RemoveAllDeletedIn();
 
-    while ( pLinkDeleted )
-        delete pLinkDeleted; // Moves up by itself
+    while (pLinkDeleted)
+    {
+        // coverity[use_after_free] - Moves up by itself
+        delete pLinkDeleted;
+    }
 
     RemoveAllDependent();
 }