[Libreoffice-commits] core.git: sc/inc sc/source
Noel Grandin
noel.grandin at collabora.co.uk
Fri Nov 11 07:02:50 UTC 2016
sc/inc/attrib.hxx | 4 ++--
sc/inc/column.hxx | 2 +-
sc/inc/dociter.hxx | 2 +-
sc/inc/document.hxx | 2 +-
sc/inc/drawpage.hxx | 2 +-
sc/inc/drwlayer.hxx | 4 ++--
sc/inc/editutil.hxx | 6 ++----
sc/inc/filter.hxx | 2 +-
sc/inc/formulacell.hxx | 2 +-
sc/inc/hints.hxx | 2 +-
sc/inc/olinetab.hxx | 2 +-
sc/inc/progress.hxx | 2 +-
sc/inc/reffind.hxx | 2 +-
sc/inc/scabstdlg.hxx | 8 ++++----
sc/inc/table.hxx | 2 +-
sc/inc/unitconv.hxx | 2 +-
sc/source/filter/inc/ftools.hxx | 2 +-
sc/source/ui/attrdlg/scdlgfact.hxx | 8 ++++----
18 files changed, 27 insertions(+), 29 deletions(-)
New commits:
commit a5b4046eb93c950296dee846bc1444921e5bf332
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Thu Nov 10 16:03:56 2016 +0200
loplugin:countusersofdefaultparams in sc(part2)
Change-Id: I1e2a0969ca7e9e0f75079a171150269dfed26507
Reviewed-on: https://gerrit.libreoffice.org/30755
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/sc/inc/attrib.hxx b/sc/inc/attrib.hxx
index 8247b19..3b71b8c 100644
--- a/sc/inc/attrib.hxx
+++ b/sc/inc/attrib.hxx
@@ -58,7 +58,7 @@ class SC_DLLPUBLIC ScMergeAttr: public SfxPoolItem
public:
static SfxPoolItem* CreateDefault();
ScMergeAttr();
- ScMergeAttr( SCsCOL nCol, SCsROW nRow = 0);
+ ScMergeAttr( SCsCOL nCol, SCsROW nRow );
ScMergeAttr( const ScMergeAttr& );
virtual ~ScMergeAttr() override;
@@ -284,7 +284,7 @@ class ScDoubleItem : public SfxPoolItem
{
public:
static SfxPoolItem* CreateDefault();
- ScDoubleItem( sal_uInt16 nWhich, double nVal=0 );
+ ScDoubleItem( sal_uInt16 nWhich, double nVal );
ScDoubleItem( const ScDoubleItem& rItem );
virtual ~ScDoubleItem() override;
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index c5940b0..8a1a370 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -530,7 +530,7 @@ public:
void EndListeningFormulaCells(
sc::EndListeningContext& rCxt, SCROW nRow1, SCROW nRow2,
- SCROW* pStartRow, SCROW* pEndRow = nullptr );
+ SCROW* pStartRow, SCROW* pEndRow );
void StartListening( SvtListener& rLst, SCROW nRow );
void EndListening( SvtListener& rLst, SCROW nRow );
diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx
index 0f48bae..f314278 100644
--- a/sc/inc/dociter.hxx
+++ b/sc/inc/dociter.hxx
@@ -572,7 +572,7 @@ public:
*/
explicit ScDocRowHeightUpdater(
ScDocument& rDoc, OutputDevice* pOutDev, double fPPTX, double fPPTY,
- const ::std::vector<TabRanges>* pTabRangesArray = nullptr);
+ const ::std::vector<TabRanges>* pTabRangesArray);
void update();
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 1a710a0..6caaa52 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1452,7 +1452,7 @@ public:
void CopyFromClip( const ScRange& rDestRange, const ScMarkData& rMark,
InsertDeleteFlags nInsFlag,
ScDocument* pRefUndoDoc,
- ScDocument* pClipDoc = nullptr,
+ ScDocument* pClipDoc,
bool bResetCut = true,
bool bAsLink = false,
bool bIncludeFiltered = true,
diff --git a/sc/inc/drawpage.hxx b/sc/inc/drawpage.hxx
index 6044600..8f93482 100644
--- a/sc/inc/drawpage.hxx
+++ b/sc/inc/drawpage.hxx
@@ -29,7 +29,7 @@ class ScDrawPage: public FmFormPage
ScDrawPage& operator=(const ScDrawPage&) = delete;
public:
- explicit ScDrawPage(ScDrawLayer& rNewModel, bool bMasterPage = false);
+ explicit ScDrawPage(ScDrawLayer& rNewModel, bool bMasterPage);
virtual ~ScDrawPage() override;
virtual ScDrawPage* Clone() const override;
diff --git a/sc/inc/drwlayer.hxx b/sc/inc/drwlayer.hxx
index 09d5919..65b9eba 100644
--- a/sc/inc/drwlayer.hxx
+++ b/sc/inc/drwlayer.hxx
@@ -40,7 +40,7 @@ class ScTabDeletedHint : public SfxHint
private:
SCTAB nTab;
public:
- ScTabDeletedHint( SCTAB nTabNo = SCTAB_MAX );
+ ScTabDeletedHint( SCTAB nTabNo );
virtual ~ScTabDeletedHint() override;
SCTAB GetTab() const { return nTab; }
@@ -51,7 +51,7 @@ class ScTabSizeChangedHint : public SfxHint
private:
SCTAB nTab;
public:
- ScTabSizeChangedHint( SCTAB nTabNo = SCTAB_MAX );
+ ScTabSizeChangedHint( SCTAB nTabNo );
virtual ~ScTabSizeChangedHint() override;
SCTAB GetTab() const { return nTab; }
diff --git a/sc/inc/editutil.hxx b/sc/inc/editutil.hxx
index 0352f79..e71976e 100644
--- a/sc/inc/editutil.hxx
+++ b/sc/inc/editutil.hxx
@@ -110,8 +110,7 @@ protected:
bool bDeleteEnginePool;
bool bDeleteDefaults;
- ScEnginePoolHelper( SfxItemPool* pEnginePool,
- bool bDeleteEnginePool = false );
+ ScEnginePoolHelper( SfxItemPool* pEnginePool, bool bDeleteEnginePool );
ScEnginePoolHelper( const ScEnginePoolHelper& rOrg );
virtual ~ScEnginePoolHelper();
};
@@ -236,8 +235,7 @@ class ScNoteEditEngine : public ScEditEngineDefaulter
{
public:
- ScNoteEditEngine( SfxItemPool* pEnginePool,
- SfxItemPool* pTextObjectPool = nullptr );
+ ScNoteEditEngine( SfxItemPool* pEnginePool, SfxItemPool* pTextObjectPool );
};
diff --git a/sc/inc/filter.hxx b/sc/inc/filter.hxx
index f0c576c..c96e9c2 100644
--- a/sc/inc/filter.hxx
+++ b/sc/inc/filter.hxx
@@ -86,7 +86,7 @@ class SAL_DLLPUBLIC_RTTI ScFormatFilterPlugin {
const rtl_TextEncoding eSrc ) = 0;
virtual FltError ScImportRTF( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange ) = 0;
virtual FltError ScImportHTML( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange, double nOutputFactor,
- bool bCalcWidthHeight = true, SvNumberFormatter* pFormatter = nullptr, bool bConvertDate = true ) = 0;
+ bool bCalcWidthHeight, SvNumberFormatter* pFormatter = nullptr, bool bConvertDate = true ) = 0;
// various import helpers
virtual ScEEAbsImport *CreateRTFImport( ScDocument* pDoc, const ScRange& rRange ) = 0;
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index d30faca..180c856 100644
--- a/sc/inc/formulacell.hxx
+++ b/sc/inc/formulacell.hxx
@@ -220,7 +220,7 @@ public:
short GetFormatType() const { return nFormatType; }
void Compile(const OUString& rFormula,
bool bNoListening,
- const formula::FormulaGrammar::Grammar = formula::FormulaGrammar::GRAM_DEFAULT );
+ const formula::FormulaGrammar::Grammar );
void Compile(
sc::CompileFormulaContext& rCxt, const OUString& rFormula, bool bNoListening = false );
diff --git a/sc/inc/hints.hxx b/sc/inc/hints.hxx
index bb08e31..2ad9f1e 100644
--- a/sc/inc/hints.hxx
+++ b/sc/inc/hints.hxx
@@ -32,7 +32,7 @@ class ScPaintHint : public SfxHint
public:
ScPaintHint() = delete;
- ScPaintHint( const ScRange& rRng, PaintPartFlags nPaint = PaintPartFlags::All );
+ ScPaintHint( const ScRange& rRng, PaintPartFlags nPaint );
virtual ~ScPaintHint() override;
void SetPrintFlag(bool bSet) { bPrint = bSet; }
diff --git a/sc/inc/olinetab.hxx b/sc/inc/olinetab.hxx
index 02f4d70..e78b651 100644
--- a/sc/inc/olinetab.hxx
+++ b/sc/inc/olinetab.hxx
@@ -37,7 +37,7 @@ class ScOutlineEntry
bool bVisible;
public:
- ScOutlineEntry( SCCOLROW nNewStart, SCCOLROW nNewSize, bool bNewHidden = false );
+ ScOutlineEntry( SCCOLROW nNewStart, SCCOLROW nNewSize, bool bNewHidden );
ScOutlineEntry( const ScOutlineEntry& rEntry );
SC_DLLPUBLIC SCCOLROW GetStart() const { return nStart;}
diff --git a/sc/inc/progress.hxx b/sc/inc/progress.hxx
index 249a4e9..89fe38a 100644
--- a/sc/inc/progress.hxx
+++ b/sc/inc/progress.hxx
@@ -70,7 +70,7 @@ public:
ScProgress( SfxObjectShell* pObjSh,
const OUString& rText,
sal_uLong nRange,
- bool bWait = true );
+ bool bWait );
~ScProgress();
#ifdef SC_PROGRESS_CXX
diff --git a/sc/inc/reffind.hxx b/sc/inc/reffind.hxx
index 2cc64da..9cb3bd0 100644
--- a/sc/inc/reffind.hxx
+++ b/sc/inc/reffind.hxx
@@ -36,7 +36,7 @@ class ScRefFinder
public:
ScRefFinder(
- const OUString& rFormula, const ScAddress& rPos, ScDocument* pDoc = nullptr,
+ const OUString& rFormula, const ScAddress& rPos, ScDocument* pDoc,
formula::FormulaGrammar::AddressConvention eConvP = formula::FormulaGrammar::CONV_OOO );
~ScRefFinder();
diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index bfbd5ad..9b9b130 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -406,7 +406,7 @@ public:
ScViewData *pViewData) = 0;
virtual VclPtr<AbstractScColRowLabelDlg> CreateScColRowLabelDlg (vcl::Window* pParent,
bool bCol,
- bool bRow = false) = 0;
+ bool bRow) = 0;
virtual VclPtr<AbstractScSortWarningDlg> CreateScSortWarningDlg(vcl::Window* pParent, const OUString& rExtendText, const OUString& rCurrentText ) = 0;
@@ -458,7 +458,7 @@ public:
long nCurrent,
long nDefault,
FieldUnit eFUnit,
- sal_uInt16 nDecimals = 2,
+ sal_uInt16 nDecimals,
long nMaximum = 1000,
long nMinimum = 0 ) = 0;
@@ -497,7 +497,7 @@ public:
sal_uInt16 nOrient ) = 0;
virtual VclPtr<AbstractScNewScenarioDlg> CreateScNewScenarioDlg ( vcl::Window* pParent, const OUString& rName,
- bool bEdit, bool bSheetProtected = false ) = 0;
+ bool bEdit, bool bSheetProtected ) = 0;
virtual VclPtr<AbstractScShowTabDlg> CreateScShowTabDlg(vcl::Window* pParent) = 0;
virtual VclPtr<AbstractScStringInputDlg> CreateScStringInputDlg ( vcl::Window* pParent,
@@ -512,7 +512,7 @@ public:
const Color& rDefaultColor ) = 0; //Currently selected Color
virtual VclPtr<AbstractScImportOptionsDlg> CreateScImportOptionsDlg ( bool bAscii,
- const ScImportOptions* pOptions = nullptr,
+ const ScImportOptions* pOptions,
const OUString* pStrTitle = nullptr,
bool bMultiByte = false,
bool bOnlyDbtoolsEncodings = false,
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index aab1453..0221fd9 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -410,7 +410,7 @@ public:
void InsertRow( SCCOL nStartCol, SCCOL nEndCol, SCROW nStartRow, SCSIZE nSize );
void DeleteRow(
const sc::ColumnSet& rRegroupCols, SCCOL nStartCol, SCCOL nEndCol, SCROW nStartRow, SCSIZE nSize,
- bool* pUndoOutline, std::vector<ScAddress>* pGroupPos = nullptr );
+ bool* pUndoOutline, std::vector<ScAddress>* pGroupPos );
bool TestInsertCol( SCROW nStartRow, SCROW nEndRow, SCSIZE nSize ) const;
void InsertCol(
diff --git a/sc/inc/unitconv.hxx b/sc/inc/unitconv.hxx
index 5c68325..dc756c9 100644
--- a/sc/inc/unitconv.hxx
+++ b/sc/inc/unitconv.hxx
@@ -30,7 +30,7 @@ class ScUnitConverterData
public:
ScUnitConverterData( const OUString& rFromUnit,
- const OUString& rToUnit, double fValue = 1.0 );
+ const OUString& rToUnit, double fValue );
ScUnitConverterData( const ScUnitConverterData& );
~ScUnitConverterData();
diff --git a/sc/source/filter/inc/ftools.hxx b/sc/source/filter/inc/ftools.hxx
index 1b18921..10c323d 100644
--- a/sc/source/filter/inc/ftools.hxx
+++ b/sc/source/filter/inc/ftools.hxx
@@ -279,7 +279,7 @@ public:
const rtl_TextEncoding eSrc ) override;
virtual FltError ScImportRTF( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange ) override;
virtual FltError ScImportHTML( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange,
- double nOutputFactor, bool bCalcWidthHeight = true,
+ double nOutputFactor, bool bCalcWidthHeight,
SvNumberFormatter* pFormatter = nullptr, bool bConvertDate = true ) override;
virtual ScEEAbsImport *CreateRTFImport( ScDocument* pDoc, const ScRange& rRange ) override;
diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx b/sc/source/ui/attrdlg/scdlgfact.hxx
index 5af8440..30e69a2 100644
--- a/sc/source/ui/attrdlg/scdlgfact.hxx
+++ b/sc/source/ui/attrdlg/scdlgfact.hxx
@@ -421,7 +421,7 @@ public:
ScViewData *pViewData) override;
virtual VclPtr<AbstractScColRowLabelDlg> CreateScColRowLabelDlg (vcl::Window* pParent,
bool bCol,
- bool bRow = false) override;
+ bool bRow) override;
virtual VclPtr<AbstractScSortWarningDlg> CreateScSortWarningDlg(vcl::Window* pParent, const OUString& rExtendText, const OUString& rCurrentText ) override;
@@ -473,7 +473,7 @@ public:
long nCurrent,
long nDefault,
FieldUnit eFUnit,
- sal_uInt16 nDecimals = 2,
+ sal_uInt16 nDecimals,
long nMaximum = 1000,
long nMinimum = 0 ) override;
@@ -512,7 +512,7 @@ public:
sal_uInt16 nOrient ) override;
virtual VclPtr<AbstractScNewScenarioDlg> CreateScNewScenarioDlg ( vcl::Window* pParent, const OUString& rName,
- bool bEdit, bool bSheetProtected = false ) override;
+ bool bEdit, bool bSheetProtected ) override;
virtual VclPtr<AbstractScShowTabDlg> CreateScShowTabDlg(vcl::Window* pParent) override;
virtual VclPtr<AbstractScStringInputDlg> CreateScStringInputDlg ( vcl::Window* pParent,
@@ -527,7 +527,7 @@ public:
const Color& rDefaultColor ) override; //Currently selected Color
virtual VclPtr<AbstractScImportOptionsDlg> CreateScImportOptionsDlg ( bool bAscii,
- const ScImportOptions* pOptions = nullptr,
+ const ScImportOptions* pOptions,
const OUString* pStrTitle = nullptr,
bool bMultiByte = false,
bool bOnlyDbtoolsEncodings = false,
More information about the Libreoffice-commits
mailing list