[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - connectivity/source

Julien Nabet serval2412 at yahoo.fr
Sat Nov 12 08:48:30 UTC 2016


 connectivity/source/drivers/firebird/DatabaseMetaData.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 489914a676ae5aadc68063d6d41de111728f2eb4
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Fri Nov 11 20:53:49 2016 +0100

    tdf#71251: VARCHAR max length is 32765 for Firebird
    
    At least for Firebird 2.5 (see http://www.firebirdsql.org/en/firebird-technical-specifications/)
    Let's put the same for CHAR
    
    Cherry-picked from ba8a41bac3765f7b3562d357aeb13f752ea14ba4
    Reviewed-on: https://gerrit.libreoffice.org/30783
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    Tested-by: Julien Nabet <serval2412 at yahoo.fr>
    
    Change-Id: I4ab232689093b0418a7c1a9751685f41f2dabbf7
    Reviewed-on: https://gerrit.libreoffice.org/30786
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Lionel Elie Mamane <lionel at mamane.lu>

diff --git a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
index f5b1a7e..1caa8af 100644
--- a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
+++ b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
@@ -903,7 +903,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTypeInfo()
         // SQL_TEXT
         aRow[1] = new ORowSetValueDecorator(OUString("CHAR"));
         aRow[2] = new ORowSetValueDecorator(getColumnTypeFromFBType(SQL_TEXT));
-        aRow[3] = new ORowSetValueDecorator(sal_Int16(32767)); // Prevision = max length
+        aRow[3] = new ORowSetValueDecorator(sal_Int16(32765)); // Prevision = max length
         aRow[6] = new ORowSetValueDecorator(OUString("length")); // Create Params
         aRow[9] = new ORowSetValueDecorator(
                 sal_Int16(ColumnSearch::FULL)); // Searchable
@@ -915,7 +915,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTypeInfo()
         // SQL_VARYING
         aRow[1] = new ORowSetValueDecorator(OUString("VARCHAR"));
         aRow[2] = new ORowSetValueDecorator(getColumnTypeFromFBType(SQL_VARYING));
-        aRow[3] = new ORowSetValueDecorator(sal_Int16(32767)); // Prevision = max length
+        aRow[3] = new ORowSetValueDecorator(sal_Int16(32765)); // Prevision = max length
         aRow[6] = new ORowSetValueDecorator(OUString("length")); // Create Params
         aRow[9] = new ORowSetValueDecorator(
                 sal_Int16(ColumnSearch::FULL)); // Searchable


More information about the Libreoffice-commits mailing list