[Libreoffice-commits] core.git: sd/qa
Stephan Bergmann
sbergman at redhat.com
Tue Nov 22 14:38:10 UTC 2016
sd/qa/unit/dialogs-test.cxx | 3 +++
1 file changed, 3 insertions(+)
New commits:
commit 2c16af58eeb9a5092656e5df67ec504288645068
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Tue Nov 22 15:35:14 2016 +0100
Destroy item sets in SdDialogsTest::tearDown
...as they apparently hold raw pointers to objects destroyed early, so only
destroying the item sets in the SdDialogsTest dtor caused use-after-free crashes
during shutdown.
Change-Id: Ibe3848c81a56fb0db4bf1fca0eab35836aab6a66
diff --git a/sd/qa/unit/dialogs-test.cxx b/sd/qa/unit/dialogs-test.cxx
index 66a4fd6..a314986 100644
--- a/sd/qa/unit/dialogs-test.cxx
+++ b/sd/qa/unit/dialogs-test.cxx
@@ -142,6 +142,9 @@ void SdDialogsTest::setUp()
void SdDialogsTest::tearDown()
{
+ mpSfxItemSetFromSdrObject.reset();
+ mpEmptySfxItemSet.reset();
+ mpEmptyFillStyleSfxItemSet.reset();
mxComponent->dispose();
ScreenshotTest::tearDown();
}
More information about the Libreoffice-commits
mailing list