[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - filter/source

Stephan Bergmann sbergman at redhat.com
Mon Nov 28 12:16:05 UTC 2016


 filter/source/msfilter/escherex.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit df37b833618e1402504fa38316ff635c6ff92b6b
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Mon Nov 28 11:22:55 2016 +0100

    tdf#104144: Missing dashed border, "break" should be "fallthrough" after all
    
    ...5ffd2c1595d1f67f5e4b14e48188a1f37f1956b5 "Presumably missing break in switch"
    apparently decided wrongly in favor of "break" over "fallthrough".
    
    Change-Id: I90372faac84a26514f5dc936e0e393a1ca12effa
    (cherry picked from commit 787d31a94510ca3de9ce582d7b7402dfca584b23)
    Reviewed-on: https://gerrit.libreoffice.org/31313
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
    Tested-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/filter/source/msfilter/escherex.cxx b/filter/source/msfilter/escherex.cxx
index dea7097..b8b5b83 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -1059,8 +1059,7 @@ void EscherPropertyContainer::CreateLineProperties(
                         AddOpt( ESCHER_Prop_lineDashing, eDash );
                     }
                 }
-                break;
-
+                SAL_FALLTHROUGH;
                 case css::drawing::LineStyle_SOLID :
                 default:
                 {


More information about the Libreoffice-commits mailing list