[Libreoffice-commits] core.git: xmlsecurity/source

[Miklos Vajna]

 xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 7226ee0586191a495f427c2adbde68b1a47d2dbc
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Wed Nov 30 17:41:25 2016 +0100

    xmlsecurity: don't write unchanged signatures back to the file
    
    It's not useful, OTOH it can happen that something goes wrong and the
    result does not match the original.
    
    One situation when this can happen is when non-XAdES signatures are
    read, but the checkbox to write XAdES signature is enabled.
    
    Change-Id: Icafad914175b29f7c0245220258bd1420ccd7b9c
    Reviewed-on: https://gerrit.libreoffice.org/31437
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
index a3dd54a..382c212 100644
--- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
+++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
@@ -357,7 +357,8 @@ IMPL_LINK_NOARG(DigitalSignaturesDialog, SignatureHighlightHdl, SvTreeListBox*,
 
 IMPL_LINK_NOARG(DigitalSignaturesDialog, OKButtonHdl, Button*, void)
 {
-    maSignatureManager.write(m_bAdESCompliant);
+    if (mbSignaturesChanged)
+        maSignatureManager.write(m_bAdESCompliant);
 
     EndDialog(RET_OK);
 }