[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

Noel Grandin noel at peralex.com
Wed Oct 5 09:51:10 UTC 2016


 sc/inc/AccessibleFilterMenu.hxx                     |    3 --
 sc/qa/unit/functions_test.cxx                       |    7 ----
 sc/source/ui/Accessibility/AccessibleFilterMenu.cxx |    5 ---
 sc/source/ui/app/inputwin.cxx                       |   10 ------
 sc/source/ui/dbgui/textimportoptions.cxx            |    5 ---
 sc/source/ui/drawfunc/fuconstr.cxx                  |    5 ---
 sc/source/ui/drawfunc/fusel.cxx                     |   30 --------------------
 sc/source/ui/inc/acredlin.hxx                       |    2 -
 sc/source/ui/inc/fuconstr.hxx                       |    1 
 sc/source/ui/inc/fusel.hxx                          |    4 --
 sc/source/ui/inc/inputwin.hxx                       |    3 --
 sc/source/ui/inc/linkarea.hxx                       |    2 -
 sc/source/ui/inc/protectiondlg.hxx                  |    2 -
 sc/source/ui/inc/retypepassdlg.hxx                  |    2 -
 sc/source/ui/inc/textimportoptions.hxx              |    1 
 sc/source/ui/miscdlgs/acredlin.cxx                  |    5 ---
 sc/source/ui/miscdlgs/linkarea.cxx                  |    5 ---
 sc/source/ui/miscdlgs/protectiondlg.cxx             |    5 ---
 sc/source/ui/miscdlgs/retypepassdlg.cxx             |    5 ---
 sc/source/ui/vba/vbaworksheets.cxx                  |    6 ----
 sc/source/ui/vba/vbaworksheets.hxx                  |    3 --
 21 files changed, 111 deletions(-)

New commits:
commit 315c06d79256ddcc50c4817a2c93c161a01c9f8d
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Oct 5 11:48:37 2016 +0200

    loplugin:unnecessaryoverride in sc
    
    Change-Id: I149e65eb605d405be54c7340ff2e668cc18c7552

diff --git a/sc/inc/AccessibleFilterMenu.hxx b/sc/inc/AccessibleFilterMenu.hxx
index 9955d7c..fba3061 100644
--- a/sc/inc/AccessibleFilterMenu.hxx
+++ b/sc/inc/AccessibleFilterMenu.hxx
@@ -72,9 +72,6 @@ public:
 
     /// XAccessibleContext
 
-    virtual OUString SAL_CALL getAccessibleName()
-        throw (css::uno::RuntimeException, std::exception) override;
-
     virtual sal_Int32 SAL_CALL getAccessibleChildCount()
         throw (css::uno::RuntimeException, std::exception) override;
 
diff --git a/sc/qa/unit/functions_test.cxx b/sc/qa/unit/functions_test.cxx
index 3362dfd..35387c7 100644
--- a/sc/qa/unit/functions_test.cxx
+++ b/sc/qa/unit/functions_test.cxx
@@ -23,8 +23,6 @@ public:
 
     virtual void setUp() override;
 
-    virtual void tearDown() override;
-
     virtual bool load(
         const OUString &rFilter,
         const OUString &rURL,
@@ -59,11 +57,6 @@ void FunctionsTest::setUp()
     CPPUNIT_ASSERT_MESSAGE("no calc component!", m_xCalcComponent.is());
 }
 
-void FunctionsTest::tearDown()
-{
-    ScBootstrapFixture::tearDown();
-}
-
 bool FunctionsTest::load(const OUString& rFilter, const OUString& rURL,
         const OUString& rUserData, SfxFilterFlags nFilterFlags,
         SotClipboardFormatId nClipboardID,
diff --git a/sc/source/ui/Accessibility/AccessibleFilterMenu.cxx b/sc/source/ui/Accessibility/AccessibleFilterMenu.cxx
index 15a63a2..4078549 100644
--- a/sc/source/ui/Accessibility/AccessibleFilterMenu.cxx
+++ b/sc/source/ui/Accessibility/AccessibleFilterMenu.cxx
@@ -122,11 +122,6 @@ sal_Int32 ScAccessibleFilterMenu::getBackground()
 
 // XAccessibleContext
 
-OUString ScAccessibleFilterMenu::getAccessibleName() throw (RuntimeException, std::exception)
-{
-    return ScAccessibleContextBase::getAccessibleName();
-}
-
 sal_Int32 ScAccessibleFilterMenu::getAccessibleChildCount()
     throw (RuntimeException, std::exception)
 {
diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index 5f875fb..e779989 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -677,16 +677,6 @@ void ScInputWindow::SetFormulaMode( bool bSet )
     aTextWindow.SetFormulaMode(bSet);
 }
 
-void ScInputWindow::SetText( const OUString& rString )
-{
-    ToolBox::SetText(rString);
-}
-
-OUString ScInputWindow::GetText() const
-{
-    return ToolBox::GetText();
-}
-
 bool ScInputWindow::IsInputActive()
 {
     return aTextWindow.IsInputActive();
diff --git a/sc/source/ui/dbgui/textimportoptions.cxx b/sc/source/ui/dbgui/textimportoptions.cxx
index 69d6ffc..7c93e07 100644
--- a/sc/source/ui/dbgui/textimportoptions.cxx
+++ b/sc/source/ui/dbgui/textimportoptions.cxx
@@ -52,11 +52,6 @@ void ScTextImportOptionsDlg::dispose()
 }
 
 
-short ScTextImportOptionsDlg::Execute()
-{
-    return ModalDialog::Execute();
-}
-
 LanguageType ScTextImportOptionsDlg::getLanguageType() const
 {
     if (m_pRbAutomatic->IsChecked())
diff --git a/sc/source/ui/drawfunc/fuconstr.cxx b/sc/source/ui/drawfunc/fuconstr.cxx
index f8920c2..3432628 100644
--- a/sc/source/ui/drawfunc/fuconstr.cxx
+++ b/sc/source/ui/drawfunc/fuconstr.cxx
@@ -58,11 +58,6 @@ FuConstruct::~FuConstruct()
 {
 }
 
-sal_uInt8 FuConstruct::Command(const CommandEvent& rCEvt)
-{
-    return FuDraw::Command( rCEvt );
-}
-
 // Calculate and return offset at current zoom. rInOutPos is adjusted by
 // the calculated offset. rInOutPos now points to the position than when
 // scaled to 100% actually would be at the position you see at the current zoom
diff --git a/sc/source/ui/drawfunc/fusel.cxx b/sc/source/ui/drawfunc/fusel.cxx
index 9cc6382..aa0ff4b 100644
--- a/sc/source/ui/drawfunc/fusel.cxx
+++ b/sc/source/ui/drawfunc/fusel.cxx
@@ -79,11 +79,6 @@ FuSelection::~FuSelection()
 {
 }
 
-sal_uInt8 FuSelection::Command(const CommandEvent& rCEvt)
-{
-    return FuDraw::Command( rCEvt );
-}
-
 /*************************************************************************
 |*
 |* MouseButtonDown-event
@@ -572,29 +567,4 @@ bool FuSelection::MouseButtonUp(const MouseEvent& rMEvt)
     return bReturn;
 }
 
-/*************************************************************************
-|*
-|* Function aktivieren
-|*
-\************************************************************************/
-
-void FuSelection::Activate()
-{
-    FuDraw::Activate();
-}
-
-/*************************************************************************
-|*
-|* Function deaktivieren
-|*
-\************************************************************************/
-
-void FuSelection::Deactivate()
-{
-    /**************************************************************************
-    * Hide Cursor
-    **************************************************************************/
-    FuDraw::Deactivate();
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/acredlin.hxx b/sc/source/ui/inc/acredlin.hxx
index 8d036f7..c12f316 100644
--- a/sc/source/ui/inc/acredlin.hxx
+++ b/sc/source/ui/inc/acredlin.hxx
@@ -167,8 +167,6 @@ public:
 
     void            ReInit(ScViewData* ptrViewData);
 
-    virtual bool    PreNotify( NotifyEvent& rNEvt ) override;
-
     void            Initialize (SfxChildWinInfo* pInfo);
     virtual void    FillInfo(SfxChildWinInfo&) const override;
 
diff --git a/sc/source/ui/inc/fuconstr.hxx b/sc/source/ui/inc/fuconstr.hxx
index 18f940a..ddb7418 100644
--- a/sc/source/ui/inc/fuconstr.hxx
+++ b/sc/source/ui/inc/fuconstr.hxx
@@ -35,7 +35,6 @@ class FuConstruct : public FuDraw
     virtual bool MouseMove(const MouseEvent& rMEvt) override;
     virtual bool MouseButtonUp(const MouseEvent& rMEvt) override;
     virtual bool MouseButtonDown(const MouseEvent& rMEvt) override;
-    virtual sal_uInt8 Command(const CommandEvent& rCEvt) override;
 
             bool SimpleMouseButtonUp(const MouseEvent& rMEvt);
 
diff --git a/sc/source/ui/inc/fusel.hxx b/sc/source/ui/inc/fusel.hxx
index bae43ec..63c2cf1 100644
--- a/sc/source/ui/inc/fusel.hxx
+++ b/sc/source/ui/inc/fusel.hxx
@@ -36,10 +36,6 @@ public:
     virtual bool MouseMove(const MouseEvent& rMEvt) override;
     virtual bool MouseButtonUp(const MouseEvent& rMEvt) override;
     virtual bool MouseButtonDown(const MouseEvent& rMEvt) override;
-    virtual sal_uInt8 Command(const CommandEvent& rCEvt) override;
-
-    virtual void Activate() override;
-    virtual void Deactivate() override;
 
     void    ActivateNoteHandles(SdrObject* pObj);
 
diff --git a/sc/source/ui/inc/inputwin.hxx b/sc/source/ui/inc/inputwin.hxx
index 63318f2..a48d4fe 100644
--- a/sc/source/ui/inc/inputwin.hxx
+++ b/sc/source/ui/inc/inputwin.hxx
@@ -265,9 +265,6 @@ public:
     virtual void    MouseMove( const MouseEvent& rMEvt ) override;
 
 protected:
-    virtual void    SetText( const OUString& rString ) override;
-    virtual OUString  GetText() const override;
-
     static bool UseSubTotal( ScRangeList* pRangeList );
     bool IsPointerAtResizePos();
 
diff --git a/sc/source/ui/inc/linkarea.hxx b/sc/source/ui/inc/linkarea.hxx
index f199e42..86037048 100644
--- a/sc/source/ui/inc/linkarea.hxx
+++ b/sc/source/ui/inc/linkarea.hxx
@@ -71,8 +71,6 @@ public:
                                         const OUString& rOptions, const OUString& rSource,
                                         sal_uLong nRefresh );
 
-    virtual short   Execute() override;          // overwritten to set dialog parent
-
     OUString       GetURL();
     OUString       GetFilter();        // may be empty
     OUString       GetOptions();       // filter options
diff --git a/sc/source/ui/inc/protectiondlg.hxx b/sc/source/ui/inc/protectiondlg.hxx
index fb19484..752fee0 100644
--- a/sc/source/ui/inc/protectiondlg.hxx
+++ b/sc/source/ui/inc/protectiondlg.hxx
@@ -40,8 +40,6 @@ public:
     virtual ~ScTableProtectionDlg() override;
     virtual void dispose() override;
 
-    virtual short Execute() override;
-
     void SetDialogData(const ScTableProtection& rData);
 
     void WriteData(ScTableProtection& rData) const;
diff --git a/sc/source/ui/inc/retypepassdlg.hxx b/sc/source/ui/inc/retypepassdlg.hxx
index bced3fb..54da764 100644
--- a/sc/source/ui/inc/retypepassdlg.hxx
+++ b/sc/source/ui/inc/retypepassdlg.hxx
@@ -105,8 +105,6 @@ public:
     virtual ~ScRetypePassInputDlg() override;
     virtual void dispose() override;
 
-    virtual short Execute() override;
-
     bool IsRemovePassword() const;
     OUString GetNewPassword() const;
 
diff --git a/sc/source/ui/inc/textimportoptions.hxx b/sc/source/ui/inc/textimportoptions.hxx
index 934df86..9a1e005 100644
--- a/sc/source/ui/inc/textimportoptions.hxx
+++ b/sc/source/ui/inc/textimportoptions.hxx
@@ -32,7 +32,6 @@ public:
     ScTextImportOptionsDlg(vcl::Window* pParent);
     virtual ~ScTextImportOptionsDlg() override;
     virtual void dispose() override;
-    virtual short Execute() override;
 
     LanguageType getLanguageType() const;
     bool isDateConversionSet() const;
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx b/sc/source/ui/miscdlgs/acredlin.cxx
index 7180c3c..0a4923d 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -735,11 +735,6 @@ SvTreeListEntry* ScAcceptChgDlg::InsertChangeActionContent(const ScChangeActionC
     return pEntry;
 }
 
-bool ScAcceptChgDlg::PreNotify( NotifyEvent& rNEvt )
-{
-    return SfxModelessDialog::PreNotify(rNEvt);
-}
-
 void ScAcceptChgDlg::UpdateView()
 {
     SvTreeListEntry* pParent=nullptr;
diff --git a/sc/source/ui/miscdlgs/linkarea.cxx b/sc/source/ui/miscdlgs/linkarea.cxx
index 37a6020..67bc379 100644
--- a/sc/source/ui/miscdlgs/linkarea.cxx
+++ b/sc/source/ui/miscdlgs/linkarea.cxx
@@ -78,11 +78,6 @@ void ScLinkedAreaDlg::dispose()
     ModalDialog::dispose();
 }
 
-short ScLinkedAreaDlg::Execute()
-{
-    return ModalDialog::Execute();
-}
-
 #define FILTERNAME_HTML  "HTML (StarCalc)"
 #define FILTERNAME_QUERY "calc_HTML_WebQuery"
 
diff --git a/sc/source/ui/miscdlgs/protectiondlg.cxx b/sc/source/ui/miscdlgs/protectiondlg.cxx
index 9375f33..ddfd337 100644
--- a/sc/source/ui/miscdlgs/protectiondlg.cxx
+++ b/sc/source/ui/miscdlgs/protectiondlg.cxx
@@ -65,11 +65,6 @@ void ScTableProtectionDlg::dispose()
     ModalDialog::dispose();
 }
 
-short ScTableProtectionDlg::Execute()
-{
-    return ModalDialog::Execute();
-}
-
 void ScTableProtectionDlg::SetDialogData(const ScTableProtection& rData)
 {
     for (sal_uInt16 i = 0; i < nOptionCount; ++i)
diff --git a/sc/source/ui/miscdlgs/retypepassdlg.cxx b/sc/source/ui/miscdlgs/retypepassdlg.cxx
index 1a9a8e1..4ab1183 100644
--- a/sc/source/ui/miscdlgs/retypepassdlg.cxx
+++ b/sc/source/ui/miscdlgs/retypepassdlg.cxx
@@ -343,11 +343,6 @@ void ScRetypePassInputDlg::dispose()
     ModalDialog::dispose();
 }
 
-short ScRetypePassInputDlg::Execute()
-{
-    return ModalDialog::Execute();
-}
-
 bool ScRetypePassInputDlg::IsRemovePassword() const
 {
     return m_pBtnRemovePassword->IsChecked();
diff --git a/sc/source/ui/vba/vbaworksheets.cxx b/sc/source/ui/vba/vbaworksheets.cxx
index ccb1cdd..7340fc2 100644
--- a/sc/source/ui/vba/vbaworksheets.cxx
+++ b/sc/source/ui/vba/vbaworksheets.cxx
@@ -462,12 +462,6 @@ ScVbaWorksheets::Item(const uno::Any& Index, const uno::Any& Index2)
     return  ScVbaWorksheets_BASE::Item( Index, Index2 );
 }
 
-uno::Any
-ScVbaWorksheets::getItemByStringIndex( const OUString& sIndex ) throw (uno::RuntimeException)
-{
-    return ScVbaWorksheets_BASE::getItemByStringIndex( sIndex );
-}
-
 OUString
 ScVbaWorksheets::getServiceImplName()
 {
diff --git a/sc/source/ui/vba/vbaworksheets.hxx b/sc/source/ui/vba/vbaworksheets.hxx
index 286f68e..e8a13e7 100644
--- a/sc/source/ui/vba/vbaworksheets.hxx
+++ b/sc/source/ui/vba/vbaworksheets.hxx
@@ -35,9 +35,6 @@ class ScVbaWorksheets : public ScVbaWorksheets_BASE
 {
     css::uno::Reference< css::frame::XModel > mxModel;
     css::uno::Reference< css::sheet::XSpreadsheets > m_xSheets;
-protected:
-    // ScVbaWorksheets_BASE
-    virtual css::uno::Any getItemByStringIndex( const OUString& sIndex ) throw (css::uno::RuntimeException) override;
 public:
     ScVbaWorksheets( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext > & xContext, const css::uno::Reference< css::container::XIndexAccess >& xSheets, const css::uno::Reference< css::frame::XModel >& xModel );
     ScVbaWorksheets( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext > & xContext, const css::uno::Reference< css::container::XEnumerationAccess >& xEnum,  const css::uno::Reference< css::frame::XModel >& xModel );


More information about the Libreoffice-commits mailing list