[Libreoffice-commits] core.git: accessibility/inc accessibility/source basctl/source chart2/source
Noel Grandin
noel at peralex.com
Wed Oct 5 11:15:34 UTC 2016
accessibility/inc/standard/vclxaccessiblefixedhyperlink.hxx | 3 -
accessibility/inc/standard/vclxaccessiblefixedtext.hxx | 1
accessibility/inc/standard/vclxaccessiblelistitem.hxx | 3 -
accessibility/source/standard/vclxaccessiblefixedhyperlink.cxx | 13 --------
accessibility/source/standard/vclxaccessiblefixedtext.cxx | 7 ----
accessibility/source/standard/vclxaccessiblelistitem.cxx | 7 ----
basctl/source/basicide/moduldlg.cxx | 5 ---
basctl/source/basicide/moduldlg.hxx | 2 -
basctl/source/dlged/dlgedobj.cxx | 6 ---
basctl/source/inc/dlgedobj.hxx | 1
chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx | 6 ---
chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx | 3 -
chart2/source/controller/dialogs/tp_ChartType.cxx | 16 ----------
chart2/source/controller/dialogs/tp_Scale.cxx | 5 ---
chart2/source/controller/dialogs/tp_Scale.hxx | 2 -
chart2/source/view/charttypes/BubbleChart.cxx | 5 ---
chart2/source/view/charttypes/BubbleChart.hxx | 2 -
chart2/source/view/charttypes/NetChart.cxx | 5 ---
chart2/source/view/charttypes/NetChart.hxx | 1
19 files changed, 93 deletions(-)
New commits:
commit 708253a21474cc3797c65d6f053760ab9c3299a3
Author: Noel Grandin <noel at peralex.com>
Date: Wed Oct 5 13:13:06 2016 +0200
loplugin:unnecessaryoverride in accessibility..chart2
Change-Id: I14ba52fe8352f8bbdfcaa90177f4f3ac9f0e08b1
diff --git a/accessibility/inc/standard/vclxaccessiblefixedhyperlink.hxx b/accessibility/inc/standard/vclxaccessiblefixedhyperlink.hxx
index 420f7e8..da53411 100644
--- a/accessibility/inc/standard/vclxaccessiblefixedhyperlink.hxx
+++ b/accessibility/inc/standard/vclxaccessiblefixedhyperlink.hxx
@@ -31,9 +31,6 @@ class VCLXAccessibleFixedHyperlink : public VCLXAccessibleTextComponent
protected:
virtual ~VCLXAccessibleFixedHyperlink() override;
- virtual void FillAccessibleStateSet( utl::AccessibleStateSetHelper& rStateSet ) override;
- virtual void implGetLineBoundary( css::i18n::Boundary& rBoundary, sal_Int32 nIndex ) override;
-
public:
VCLXAccessibleFixedHyperlink( VCLXWindow* pVCLXindow );
diff --git a/accessibility/inc/standard/vclxaccessiblefixedtext.hxx b/accessibility/inc/standard/vclxaccessiblefixedtext.hxx
index d1fc6b9..4f870be 100644
--- a/accessibility/inc/standard/vclxaccessiblefixedtext.hxx
+++ b/accessibility/inc/standard/vclxaccessiblefixedtext.hxx
@@ -32,7 +32,6 @@ protected:
virtual ~VCLXAccessibleFixedText() override;
virtual void FillAccessibleStateSet( utl::AccessibleStateSetHelper& rStateSet ) override;
- virtual void implGetLineBoundary( css::i18n::Boundary& rBoundary, sal_Int32 nIndex ) override;
public:
VCLXAccessibleFixedText( VCLXWindow* pVCLXindow );
diff --git a/accessibility/inc/standard/vclxaccessiblelistitem.hxx b/accessibility/inc/standard/vclxaccessiblelistitem.hxx
index ca74da8..405ecb5 100644
--- a/accessibility/inc/standard/vclxaccessiblelistitem.hxx
+++ b/accessibility/inc/standard/vclxaccessiblelistitem.hxx
@@ -104,9 +104,6 @@ public:
void SetSelected( bool _bSelected );
void SetVisible( bool _bVisible );
- // XInterface
- virtual css::uno::Any SAL_CALL queryInterface( const css::uno::Type& aType ) throw(css::uno::RuntimeException, std::exception) override;
-
// XTypeProvider
virtual css::uno::Sequence< sal_Int8 > SAL_CALL getImplementationId() throw (css::uno::RuntimeException, std::exception) override;
diff --git a/accessibility/source/standard/vclxaccessiblefixedhyperlink.cxx b/accessibility/source/standard/vclxaccessiblefixedhyperlink.cxx
index 9ea2234..279c6e7 100644
--- a/accessibility/source/standard/vclxaccessiblefixedhyperlink.cxx
+++ b/accessibility/source/standard/vclxaccessiblefixedhyperlink.cxx
@@ -36,19 +36,6 @@ VCLXAccessibleFixedHyperlink::~VCLXAccessibleFixedHyperlink()
}
-void VCLXAccessibleFixedHyperlink::FillAccessibleStateSet( utl::AccessibleStateSetHelper& rStateSet )
-{
- VCLXAccessibleTextComponent::FillAccessibleStateSet( rStateSet );
-}
-
-
-void VCLXAccessibleFixedHyperlink::implGetLineBoundary( i18n::Boundary& rBoundary, sal_Int32 nIndex )
-{
- // TODO
- OCommonAccessibleText::implGetLineBoundary( rBoundary, nIndex );
-}
-
-
// XServiceInfo
diff --git a/accessibility/source/standard/vclxaccessiblefixedtext.cxx b/accessibility/source/standard/vclxaccessiblefixedtext.cxx
index f7adece..6ac0adb 100644
--- a/accessibility/source/standard/vclxaccessiblefixedtext.cxx
+++ b/accessibility/source/standard/vclxaccessiblefixedtext.cxx
@@ -53,13 +53,6 @@ void VCLXAccessibleFixedText::FillAccessibleStateSet( utl::AccessibleStateSetHel
}
-void VCLXAccessibleFixedText::implGetLineBoundary( i18n::Boundary& rBoundary, sal_Int32 nIndex )
-{
- // TODO
- OCommonAccessibleText::implGetLineBoundary( rBoundary, nIndex );
-}
-
-
// XServiceInfo
diff --git a/accessibility/source/standard/vclxaccessiblelistitem.cxx b/accessibility/source/standard/vclxaccessiblelistitem.cxx
index c21cee4..49b9e8f 100644
--- a/accessibility/source/standard/vclxaccessiblelistitem.cxx
+++ b/accessibility/source/standard/vclxaccessiblelistitem.cxx
@@ -144,13 +144,6 @@ void VCLXAccessibleListItem::implGetSelection( sal_Int32& nStartIndex, sal_Int32
nEndIndex = 0;
}
-// XInterface
-
-Any SAL_CALL VCLXAccessibleListItem::queryInterface( Type const & rType ) throw (RuntimeException, std::exception)
-{
- return VCLXAccessibleListItem_BASE::queryInterface( rType );
-}
-
// XTypeProvider
Sequence< sal_Int8 > VCLXAccessibleListItem::getImplementationId() throw (RuntimeException, std::exception)
diff --git a/basctl/source/basicide/moduldlg.cxx b/basctl/source/basicide/moduldlg.cxx
index 386069e..8636097 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -501,11 +501,6 @@ void OrganizeDialog::dispose()
TabDialog::dispose();
};
-short OrganizeDialog::Execute()
-{
- return TabDialog::Execute();
-}
-
IMPL_LINK( OrganizeDialog, ActivatePageHdl, TabControl *, pTabCtrl, void )
{
sal_uInt16 nId = pTabCtrl->GetCurPageId();
diff --git a/basctl/source/basicide/moduldlg.hxx b/basctl/source/basicide/moduldlg.hxx
index 20a53ba..c196c48 100644
--- a/basctl/source/basicide/moduldlg.hxx
+++ b/basctl/source/basicide/moduldlg.hxx
@@ -176,8 +176,6 @@ public:
virtual ~OrganizeDialog() override;
virtual void dispose() override;
- virtual short Execute() override;
-
DECL_LINK( ActivatePageHdl, TabControl*, void );
};
diff --git a/basctl/source/dlged/dlgedobj.cxx b/basctl/source/dlged/dlgedobj.cxx
index e57f329..10020bf 100644
--- a/basctl/source/dlged/dlgedobj.cxx
+++ b/basctl/source/dlged/dlgedobj.cxx
@@ -82,12 +82,6 @@ DlgEdObj::~DlgEdObj()
EndListening(true);
}
-void DlgEdObj::SetPage(SdrPage* _pNewPage)
-{
- // now set the page
- SdrUnoObj::SetPage(_pNewPage);
-}
-
namespace
{
/* returns the DlgEdForm which the given DlgEdObj belongs to
diff --git a/basctl/source/inc/dlgedobj.hxx b/basctl/source/inc/dlgedobj.hxx
index 1d7ccb7..c103b2f 100644
--- a/basctl/source/inc/dlgedobj.hxx
+++ b/basctl/source/inc/dlgedobj.hxx
@@ -88,7 +88,6 @@ protected:
public:
virtual ~DlgEdObj() override;
- virtual void SetPage(SdrPage* pNewPage) override;
void SetDlgEdForm( DlgEdForm* pForm ) { pDlgEdForm = pForm; }
DlgEdForm* GetDlgEdForm() const { return pDlgEdForm; }
diff --git a/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx b/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx
index ce85f0f..fb1fa03 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx
@@ -101,12 +101,6 @@ Any WrappedD3DTransformMatrixProperty::getPropertyValue( const Reference< beans:
return WrappedProperty::getPropertyValue( xInnerPropertySet );
}
-Any WrappedD3DTransformMatrixProperty::getPropertyDefault( const Reference< beans::XPropertyState >& xInnerPropertyState ) const
- throw (beans::UnknownPropertyException, lang::WrappedTargetException, uno::RuntimeException)
-{
- return WrappedProperty::getPropertyDefault( xInnerPropertyState );
-}
-
} //namespace wrapper
} //namespace chart
diff --git a/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx b/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx
index 7e33bd9..36564ad 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx
@@ -50,9 +50,6 @@ public:
virtual css::uno::Any getPropertyValue( const css::uno::Reference< css::beans::XPropertySet >& xInnerPropertySet ) const
throw (css::beans::UnknownPropertyException, css::lang::WrappedTargetException, css::uno::RuntimeException) override;
- virtual css::uno::Any getPropertyDefault( const css::uno::Reference< css::beans::XPropertyState >& xInnerPropertyState ) const
- throw (css::beans::UnknownPropertyException, css::lang::WrappedTargetException, css::uno::RuntimeException) override;
-
private:
std::shared_ptr< Chart2ModelContact > m_spChart2ModelContact;
};
diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx b/chart2/source/controller/dialogs/tp_ChartType.cxx
index 99447ea..fc1c9be 100644
--- a/chart2/source/controller/dialogs/tp_ChartType.cxx
+++ b/chart2/source/controller/dialogs/tp_ChartType.cxx
@@ -316,8 +316,6 @@ public:
void fillControls( const ChartTypeParameter& rParameter );
void fillParameter( ChartTypeParameter& rParameter, bool bSmoothLines );
- virtual void StateChanged( StateChangedType nType ) override;
-
private:
DECL_LINK( SplineTypeListBoxHdl, ListBox&, void );
@@ -354,11 +352,6 @@ void SplinePropertiesDialog::dispose()
ModalDialog::dispose();
}
-void SplinePropertiesDialog::StateChanged( StateChangedType nType )
-{
- Dialog::StateChanged( nType );
-}
-
void SplinePropertiesDialog::fillControls( const ChartTypeParameter& rParameter )
{
switch(rParameter.eCurveStyle)
@@ -408,10 +401,6 @@ public:
void fillControls( const ChartTypeParameter& rParameter );
void fillParameter( ChartTypeParameter& rParameter, bool bSteppedLines );
- virtual void StateChanged( StateChangedType nType ) override;
-
-private:
-
private:
VclPtr<RadioButton> m_pRB_Start;
VclPtr<RadioButton> m_pRB_End;
@@ -439,11 +428,6 @@ void SteppedPropertiesDialog::dispose()
ModalDialog::dispose();
}
-void SteppedPropertiesDialog::StateChanged( StateChangedType nType )
-{
- Dialog::StateChanged( nType );
-}
-
void SteppedPropertiesDialog::fillControls( const ChartTypeParameter& rParameter )
{
switch(rParameter.eCurveStyle)
diff --git a/chart2/source/controller/dialogs/tp_Scale.cxx b/chart2/source/controller/dialogs/tp_Scale.cxx
index 3edb725..c588718 100644
--- a/chart2/source/controller/dialogs/tp_Scale.cxx
+++ b/chart2/source/controller/dialogs/tp_Scale.cxx
@@ -164,11 +164,6 @@ IMPL_STATIC_LINK(
rFmtField.SetDefaultValue( rFmtField.GetValue() );
}
-void ScaleTabPage::StateChanged( StateChangedType nType )
-{
- TabPage::StateChanged( nType );
-}
-
void ScaleTabPage::EnableControls()
{
bool bValueAxis = chart2::AxisType::REALNUMBER == m_nAxisType
diff --git a/chart2/source/controller/dialogs/tp_Scale.hxx b/chart2/source/controller/dialogs/tp_Scale.hxx
index 2eb8560..33a5858 100644
--- a/chart2/source/controller/dialogs/tp_Scale.hxx
+++ b/chart2/source/controller/dialogs/tp_Scale.hxx
@@ -47,8 +47,6 @@ public:
void ShowAxisOrigin( bool bShowOrigin );
- virtual void StateChanged( StateChangedType nType ) override;
-
private:
VclPtr<CheckBox> m_pCbxReverse;
VclPtr<CheckBox> m_pCbxLogarithm;
diff --git a/chart2/source/view/charttypes/BubbleChart.cxx b/chart2/source/view/charttypes/BubbleChart.cxx
index df523dd..a9e9dab 100644
--- a/chart2/source/view/charttypes/BubbleChart.cxx
+++ b/chart2/source/view/charttypes/BubbleChart.cxx
@@ -159,11 +159,6 @@ drawing::Direction3D BubbleChart::getPreferredDiagramAspectRatio() const
return drawing::Direction3D(-1,-1,-1);
}
-void BubbleChart::addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot )
-{
- VSeriesPlotter::addSeries( pSeries, zSlot, xSlot, ySlot );
-}
-
//better performance for big data
struct FormerPoint
{
diff --git a/chart2/source/view/charttypes/BubbleChart.hxx b/chart2/source/view/charttypes/BubbleChart.hxx
index ab24ac6..6958e54 100644
--- a/chart2/source/view/charttypes/BubbleChart.hxx
+++ b/chart2/source/view/charttypes/BubbleChart.hxx
@@ -37,8 +37,6 @@ public:
virtual void createShapes() override;
- virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override;
-
virtual css::drawing::Direction3D getPreferredDiagramAspectRatio() const override;
// MinimumAndMaximumSupplier
diff --git a/chart2/source/view/charttypes/NetChart.cxx b/chart2/source/view/charttypes/NetChart.cxx
index 72777dd..b69a475 100644
--- a/chart2/source/view/charttypes/NetChart.cxx
+++ b/chart2/source/view/charttypes/NetChart.cxx
@@ -116,11 +116,6 @@ drawing::Direction3D NetChart::getPreferredDiagramAspectRatio() const
return drawing::Direction3D(1,1,1);
}
-void NetChart::addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot )
-{
- VSeriesPlotter::addSeries( pSeries, zSlot, xSlot, ySlot );
-}
-
bool NetChart::impl_createLine( VDataSeries* pSeries
, drawing::PolyPolygonShape3D* pSeriesPoly
, PlottingPositionHelper* pPosHelper )
diff --git a/chart2/source/view/charttypes/NetChart.hxx b/chart2/source/view/charttypes/NetChart.hxx
index c0b22c3..bc4d7af 100644
--- a/chart2/source/view/charttypes/NetChart.hxx
+++ b/chart2/source/view/charttypes/NetChart.hxx
@@ -39,7 +39,6 @@ public:
virtual ~NetChart() override;
virtual void createShapes() override;
- virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override;
virtual css::drawing::Direction3D getPreferredDiagramAspectRatio() const override;
More information about the Libreoffice-commits
mailing list