[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - canvas/source

Caolán McNamara caolanm at redhat.com
Thu Oct 6 10:58:51 UTC 2016


 canvas/source/cairo/cairo_canvashelper.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit fc3d4c5358b03244177b08a13268c7922ab5f4a5
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Oct 6 09:56:29 2016 +0100

    Resolves: tdf#103026 invalid dash causes CAIRO_STATUS_INVALID_DASH state
    
    (cherry picked from commit c5d355e9c9cbc94eede8f438895e192d834f7096)
    
    Change-Id: I072635ff7c67022ebfd5bdb475e390f3aab7a51c
    Reviewed-on: https://gerrit.libreoffice.org/29552
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Michael Stahl <mstahl at redhat.com>

diff --git a/canvas/source/cairo/cairo_canvashelper.cxx b/canvas/source/cairo/cairo_canvashelper.cxx
index 4800523..7f7bc11 100644
--- a/canvas/source/cairo/cairo_canvashelper.cxx
+++ b/canvas/source/cairo/cairo_canvashelper.cxx
@@ -1247,7 +1247,10 @@ namespace cairocanvas
                     break;
             }
 
-            if( strokeAttributes.DashArray.getLength() > 0 )
+            //tdf#103026 If the w scaling is 0, then all dashes become zero so
+            //cairo will set the cairo_t status to CAIRO_STATUS_INVALID_DASH
+            //and no further drawing will occur
+            if (strokeAttributes.DashArray.getLength() > 0 && w > 0.0)
             {
                 double* pDashArray = new double[ strokeAttributes.DashArray.getLength() ];
                 for( sal_Int32 i=0; i<strokeAttributes.DashArray.getLength(); i++ )


More information about the Libreoffice-commits mailing list