[Libreoffice-commits] core.git: svx/inc svx/source

Noel Grandin noel.grandin at collabora.co.uk
Wed Oct 12 06:37:35 UTC 2016


 svx/inc/dragmt3d.hxx                              |    6 +++---
 svx/inc/sdr/overlay/overlayhelpline.hxx           |    2 +-
 svx/inc/sdr/overlay/overlaymanagerbuffered.hxx    |    2 +-
 svx/inc/sdr/overlay/overlayrollingrectangle.hxx   |    2 +-
 svx/inc/sdr/overlay/overlaytools.hxx              |    4 ++--
 svx/inc/sdr/primitive2d/sdrcaptionprimitive2d.hxx |    4 ++--
 svx/inc/sxmoitm.hxx                               |    2 +-
 svx/inc/xpolyimp.hxx                              |    2 +-
 svx/source/form/fmvwimp.cxx                       |    2 +-
 svx/source/inc/filtnav.hxx                        |    4 ++--
 svx/source/inc/fmexpl.hxx                         |    2 +-
 svx/source/inc/fmundo.hxx                         |    2 +-
 svx/source/inc/gridcell.hxx                       |    2 +-
 svx/source/svdraw/svdibrow.cxx                    |    2 +-
 svx/source/svdraw/svdmrkv.cxx                     |    2 +-
 svx/source/table/celltypes.hxx                    |    2 +-
 svx/source/tbxctrls/tbcontrl.cxx                  |    2 +-
 17 files changed, 22 insertions(+), 22 deletions(-)

New commits:
commit c2808e3178b28528c23557321683b10b6ab5371f
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Tue Oct 11 11:27:13 2016 +0200

    loplugin:countusersofdefaultparams in svx
    
    Change-Id: I610d8347129ac25420730ed7bf2855a5bdd0120f
    Reviewed-on: https://gerrit.libreoffice.org/29692
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/svx/inc/dragmt3d.hxx b/svx/inc/dragmt3d.hxx
index 5097e0a..1bf8f9b 100644
--- a/svx/inc/dragmt3d.hxx
+++ b/svx/inc/dragmt3d.hxx
@@ -66,7 +66,7 @@ public:
     E3dDragMethod(
         SdrDragView &rView,
         const SdrMarkList& rMark,
-        E3dDragConstraint eConstr = E3dDragConstraint::XYZ,
+        E3dDragConstraint eConstr,
         bool bFull = false);
 
     virtual void TakeSdrDragComment(OUString& rStr) const override;
@@ -88,7 +88,7 @@ public:
     E3dDragRotate(
         SdrDragView &rView,
         const SdrMarkList& rMark,
-        E3dDragConstraint eConstr = E3dDragConstraint::XYZ,
+        E3dDragConstraint eConstr,
         bool bFull = false);
 
     virtual void MoveSdrDrag(const Point& rPnt) override;
@@ -105,7 +105,7 @@ public:
     E3dDragMove(
         SdrDragView &rView,
         const SdrMarkList& rMark,
-        SdrHdlKind eDrgHdl = SdrHdlKind::Move,
+        SdrHdlKind eDrgHdl,
         E3dDragConstraint eConstr = E3dDragConstraint::XYZ,
         bool bFull = false);
 
diff --git a/svx/inc/sdr/overlay/overlayhelpline.hxx b/svx/inc/sdr/overlay/overlayhelpline.hxx
index 7329dcf..4778312 100644
--- a/svx/inc/sdr/overlay/overlayhelpline.hxx
+++ b/svx/inc/sdr/overlay/overlayhelpline.hxx
@@ -40,7 +40,7 @@ namespace sdr
         public:
             explicit OverlayHelplineStriped(
                 const basegfx::B2DPoint& rBasePos,
-                SdrHelpLineKind eNewKind = SdrHelpLineKind::Point);
+                SdrHelpLineKind eNewKind);
             virtual ~OverlayHelplineStriped() override;
 
             // dat read access
diff --git a/svx/inc/sdr/overlay/overlaymanagerbuffered.hxx b/svx/inc/sdr/overlay/overlaymanagerbuffered.hxx
index 42fcf21..6712e49 100644
--- a/svx/inc/sdr/overlay/overlaymanagerbuffered.hxx
+++ b/svx/inc/sdr/overlay/overlaymanagerbuffered.hxx
@@ -62,7 +62,7 @@ namespace sdr
 
             OverlayManagerBuffered(
                 OutputDevice& rOutputDevice,
-                bool bRefreshWithPreRendering = false);
+                bool bRefreshWithPreRendering);
             virtual ~OverlayManagerBuffered() override;
 
         public:
diff --git a/svx/inc/sdr/overlay/overlayrollingrectangle.hxx b/svx/inc/sdr/overlay/overlayrollingrectangle.hxx
index 2cab780..7b00d90 100644
--- a/svx/inc/sdr/overlay/overlayrollingrectangle.hxx
+++ b/svx/inc/sdr/overlay/overlayrollingrectangle.hxx
@@ -46,7 +46,7 @@ namespace sdr
             OverlayRollingRectangleStriped(
                 const basegfx::B2DPoint& rBasePos,
                 const basegfx::B2DPoint& rSecondPos,
-                bool bExtendedLines = false,
+                bool bExtendedLines,
                 bool bShowBounds = true);
             virtual ~OverlayRollingRectangleStriped() override;
 
diff --git a/svx/inc/sdr/overlay/overlaytools.hxx b/svx/inc/sdr/overlay/overlaytools.hxx
index 224135b3..197cc71 100644
--- a/svx/inc/sdr/overlay/overlaytools.hxx
+++ b/svx/inc/sdr/overlay/overlaytools.hxx
@@ -95,8 +95,8 @@ namespace drawinglayer
                 const basegfx::B2DPoint& rBasePosition,
                 sal_uInt16 nCenterX,
                 sal_uInt16 nCenterY,
-                double fShearX = 0.0,
-                double fRotation = 0.0);
+                double fShearX,
+                double fRotation);
 
             // data access
             const BitmapEx& getBitmapEx() const { return maBitmapEx; }
diff --git a/svx/inc/sdr/primitive2d/sdrcaptionprimitive2d.hxx b/svx/inc/sdr/primitive2d/sdrcaptionprimitive2d.hxx
index 9037865..656e8ea 100644
--- a/svx/inc/sdr/primitive2d/sdrcaptionprimitive2d.hxx
+++ b/svx/inc/sdr/primitive2d/sdrcaptionprimitive2d.hxx
@@ -51,8 +51,8 @@ namespace drawinglayer
                 const ::basegfx::B2DHomMatrix& rTransform,
                 const attribute::SdrLineFillShadowTextAttribute& rSdrLFSTAttribute,
                 const ::basegfx::B2DPolygon& rTail,
-                double fCornerRadiusX = 0.0,
-                double fCornerRadiusY = 0.0);
+                double fCornerRadiusX,
+                double fCornerRadiusY);
 
             // compare operator
             virtual bool operator==(const BasePrimitive2D& rPrimitive) const override;
diff --git a/svx/inc/sxmoitm.hxx b/svx/inc/sxmoitm.hxx
index ec2697a..2ae11c2 100644
--- a/svx/inc/sxmoitm.hxx
+++ b/svx/inc/sxmoitm.hxx
@@ -26,7 +26,7 @@
 // Only of the measure arrows are on the outside
 class SdrMeasureOverhangItem: public SdrMetricItem {
 public:
-    SdrMeasureOverhangItem(long nVal=0): SdrMetricItem(SDRATTR_MEASUREOVERHANG,nVal)  {}
+    SdrMeasureOverhangItem(long nVal): SdrMetricItem(SDRATTR_MEASUREOVERHANG,nVal)  {}
     virtual SfxPoolItem* Clone(SfxItemPool*) const override
     {
         return new SdrMeasureOverhangItem(*this);
diff --git a/svx/inc/xpolyimp.hxx b/svx/inc/xpolyimp.hxx
index c3a455a..0fbd187 100644
--- a/svx/inc/xpolyimp.hxx
+++ b/svx/inc/xpolyimp.hxx
@@ -36,7 +36,7 @@ public:
     sal_uInt16          nResize;
     sal_uInt16          nPoints;
 
-    ImpXPolygon( sal_uInt16 nInitSize = 16, sal_uInt16 nResize=16 );
+    ImpXPolygon( sal_uInt16 nInitSize, sal_uInt16 nResize=16 );
     ImpXPolygon( const ImpXPolygon& rImpXPoly );
     ~ImpXPolygon();
 
diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx
index 4890141..2f5d539 100644
--- a/svx/source/form/fmvwimp.cxx
+++ b/svx/source/form/fmvwimp.cxx
@@ -1130,7 +1130,7 @@ namespace
 {
     void lcl_insertIntoFormComponentHierarchy_throw( const FmFormView& _rView, const SdrUnoObj& _rSdrObj,
         const Reference< XDataSource >& _rxDataSource, const OUString& _rDataSourceName,
-        const OUString& _rCommand, const sal_Int32 _nCommandType = -1 )
+        const OUString& _rCommand, const sal_Int32 _nCommandType )
     {
         FmFormPage& rPage = static_cast< FmFormPage& >( *_rView.GetSdrPageView()->GetPage() );
 
diff --git a/svx/source/inc/filtnav.hxx b/svx/source/inc/filtnav.hxx
index 6487e0a..ce5a592 100644
--- a/svx/source/inc/filtnav.hxx
+++ b/svx/source/inc/filtnav.hxx
@@ -58,11 +58,11 @@ class FmFilterAdapter;
 
 class FmFilterData
 {
-    FmParentData*           m_pParent;
+    FmParentData*    m_pParent;
     OUString         m_aText;
 
 public:
-    FmFilterData(FmParentData* pParent = nullptr, const OUString& rText = OUString())
+    FmFilterData(FmParentData* pParent, const OUString& rText = OUString())
         :m_pParent( pParent )
         ,m_aText( rText )
     {}
diff --git a/svx/source/inc/fmexpl.hxx b/svx/source/inc/fmexpl.hxx
index 122ba07..29cfa3a 100644
--- a/svx/source/inc/fmexpl.hxx
+++ b/svx/source/inc/fmexpl.hxx
@@ -243,7 +243,7 @@ public:
     FmFormData(
         const css::uno::Reference< css::form::XForm >& _rxForm,
         const ImageList& _rNormalImages,
-        FmFormData* _pParent = nullptr
+        FmFormData* _pParent
     );
 
     FmFormData( const FmFormData& rFormData );
diff --git a/svx/source/inc/fmundo.hxx b/svx/source/inc/fmundo.hxx
index 677d563..b4d3df4 100644
--- a/svx/source/inc/fmundo.hxx
+++ b/svx/source/inc/fmundo.hxx
@@ -89,7 +89,7 @@ public:
                           Action _eAction,
                           const css::uno::Reference< css::container::XIndexContainer >& xCont,
                           const css::uno::Reference< css::uno::XInterface >& xElem,
-                          sal_Int32 nIdx = -1);
+                          sal_Int32 nIdx);
     virtual ~FmUndoContainerAction() override;
 
     virtual void Undo() override;
diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx
index 38b8478..4155947 100644
--- a/svx/source/inc/gridcell.hxx
+++ b/svx/source/inc/gridcell.hxx
@@ -1071,7 +1071,7 @@ class FmXFilterCell :public FmXGridCell
 protected:
     virtual ~FmXFilterCell() override;
 public:
-    FmXFilterCell(DbGridColumn* pColumn = nullptr, DbCellControl* pControl = nullptr);
+    FmXFilterCell(DbGridColumn* pColumn, DbCellControl* pControl = nullptr);
 
 
     DECLARE_UNO3_AGG_DEFAULTS(FmXFilterCell, FmXGridCell)
diff --git a/svx/source/svdraw/svdibrow.cxx b/svx/source/svdraw/svdibrow.cxx
index d3152c5..44ab835 100644
--- a/svx/source/svdraw/svdibrow.cxx
+++ b/svx/source/svdraw/svdibrow.cxx
@@ -166,7 +166,7 @@ class ImpItemEdit: public Edit
     VclPtr<SdrItemBrowserControl>     pBrowse;
 
 public:
-    ImpItemEdit(vcl::Window* pParent, SdrItemBrowserControl* pBrowse_, WinBits nBits=0)
+    ImpItemEdit(vcl::Window* pParent, SdrItemBrowserControl* pBrowse_, WinBits nBits)
     :   Edit(pParent, nBits),
         pBrowse(pBrowse_)
     {}
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 8e61869..bc32fe6 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -72,7 +72,7 @@ class ImplMarkingOverlay
     bool                                            mbUnmarking : 1;
 
 public:
-    ImplMarkingOverlay(const SdrPaintView& rView, const basegfx::B2DPoint& rStartPos, bool bUnmarking = false);
+    ImplMarkingOverlay(const SdrPaintView& rView, const basegfx::B2DPoint& rStartPos, bool bUnmarking);
     ~ImplMarkingOverlay();
 
     void SetSecondPosition(const basegfx::B2DPoint& rNewPosition);
diff --git a/svx/source/table/celltypes.hxx b/svx/source/table/celltypes.hxx
index 0316620..66409cc 100644
--- a/svx/source/table/celltypes.hxx
+++ b/svx/source/table/celltypes.hxx
@@ -56,7 +56,7 @@ public:
         bForward is true or from nEnd (excluding to nStart (including).
         rStart must be <= rEnd.
     */
-    RangeIterator( const T& rStart, const T& rEnd, bool bForward = true )
+    RangeIterator( const T& rStart, const T& rEnd, bool bForward )
     {
         if( bForward )
         {
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 6574022..6006c4e 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -208,7 +208,7 @@ protected:
 
 public:
     SvxFontNameBox_Impl( vcl::Window* pParent, const Reference< XDispatchProvider >& rDispatchProvider,const Reference< XFrame >& _xFrame
-        , WinBits nStyle = WB_SORT
+        , WinBits nStyle
         );
     virtual ~SvxFontNameBox_Impl() override;
     virtual void dispose() override;


More information about the Libreoffice-commits mailing list