[Libreoffice-commits] core.git: svl/source

Jochen Nitschke j.nitschke+logerrit at ok.de
Thu Oct 27 06:18:09 UTC 2016


 svl/source/items/itemprop.cxx |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

New commits:
commit f53cd8826b45007d70adf2ec7b41377150d2ed67
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date:   Wed Oct 26 21:49:43 2016 +0200

    remove unused variable
    
    aSet unused since
    2ebd79b3d214c62c0997606115ebc50700d6a760
        loplugin:constantfunction: svl
    
    Change-Id: I48faf8775465ec1d5e3df94343a4373a87d03e6d
    Reviewed-on: https://gerrit.libreoffice.org/30310
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/svl/source/items/itemprop.cxx b/svl/source/items/itemprop.cxx
index c3ec9b6..e6ac2ed 100644
--- a/svl/source/items/itemprop.cxx
+++ b/svl/source/items/itemprop.cxx
@@ -187,15 +187,12 @@ void SfxItemPropertySet::getPropertyValue( const SfxItemPropertySimpleEntry& rEn
     {
         pItem->QueryValue( rAny, rEntry.nMemberId );
     }
-    else
+    else if(0 == (rEntry.nFlags & PropertyAttribute::MAYBEVOID))
     {
-        SfxItemSet aSet(*rSet.GetPool(), rEntry.nWID, rEntry.nWID);
-        if(0 == (rEntry.nFlags & PropertyAttribute::MAYBEVOID))
-            throw RuntimeException(
-                    "Property not found in ItemSet but not MAYBEVOID?", nullptr);
+        throw RuntimeException(
+            "Property not found in ItemSet but not MAYBEVOID?", nullptr);
     }
 
-
     // convert general SfxEnumItem values to specific values
     if( rEntry.aType.getTypeClass() == TypeClass_ENUM &&
          rAny.getValueTypeClass() == TypeClass_LONG )


More information about the Libreoffice-commits mailing list