[Libreoffice-commits] core.git: connectivity/source include/comphelper mysqlc/source odk/examples

Stephan Bergmann sbergman at redhat.com
Thu Oct 27 15:10:19 UTC 2016


 connectivity/source/drivers/firebird/SubComponent.hxx                  |    3 ---
 connectivity/source/inc/hsqldb/HTable.hxx                              |    3 ---
 connectivity/source/inc/mysql/YTable.hxx                               |    3 ---
 include/comphelper/IdPropArrayHelper.hxx                               |    3 ---
 include/comphelper/proparrhlp.hxx                                      |    3 ---
 mysqlc/source/mysqlc_subcomponent.hxx                                  |    3 ---
 odk/examples/DevelopersGuide/Database/DriverSkeleton/OSubComponent.hxx |    3 ---
 7 files changed, 21 deletions(-)

New commits:
commit d4398c776706fd3a5bc3b3fa9f8a3e965a7a6306
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Oct 27 17:08:09 2016 +0200

    Remove bogus comments about ~IPropertyArrayHelper not being virtual
    
    ...which isn't true at least ever since b525a3115f54576017a576ff842dede5e2e3545d
    "initial import", but got copy/pasted all over the place
    
    Change-Id: I47d3d8a594aef3ac3736d7176ae964a118821014

diff --git a/connectivity/source/drivers/firebird/SubComponent.hxx b/connectivity/source/drivers/firebird/SubComponent.hxx
index 5c87097..609c07a 100644
--- a/connectivity/source/drivers/firebird/SubComponent.hxx
+++ b/connectivity/source/drivers/firebird/SubComponent.hxx
@@ -80,9 +80,6 @@ namespace connectivity
                 This method needs to be implemented in derived classes.
                 <BR>
                 The method gets called with s_aMutex acquired.
-                <BR>
-                as long as IPropertyArrayHelper has no virtual destructor, the implementation of ~OPropertyArrayUsageHelper
-                assumes that you created an ::cppu::OPropertyArrayHelper when deleting s_pProps.
                 @return                         an pointer to the newly created array helper. Must not be NULL.
             */
             virtual ::cppu::IPropertyArrayHelper* createArrayHelper( ) const = 0;
diff --git a/connectivity/source/inc/hsqldb/HTable.hxx b/connectivity/source/inc/hsqldb/HTable.hxx
index 4673e41..08ed264 100644
--- a/connectivity/source/inc/hsqldb/HTable.hxx
+++ b/connectivity/source/inc/hsqldb/HTable.hxx
@@ -65,9 +65,6 @@ namespace connectivity
                 This method needs to be implemented in derived classes.
                 <BR>
                 The method gets called with s_aMutex acquired.
-                <BR>
-                as long as IPropertyArrayHelper has no virtual destructor, the implementation of ~OPropertyArrayUsageHelper
-                assumes that you created an ::cppu::OPropertyArrayHelper when deleting s_pProps.
                 @return                         an pointer to the newly created array helper. Must not be NULL.
             */
             virtual ::cppu::IPropertyArrayHelper* createArrayHelper(sal_Int32 nId) const override;
diff --git a/connectivity/source/inc/mysql/YTable.hxx b/connectivity/source/inc/mysql/YTable.hxx
index a8055e6..8fca785 100644
--- a/connectivity/source/inc/mysql/YTable.hxx
+++ b/connectivity/source/inc/mysql/YTable.hxx
@@ -72,9 +72,6 @@ namespace connectivity
                 This method needs to be implemented in derived classes.
                 <BR>
                 The method gets called with s_aMutex acquired.
-                <BR>
-                as long as IPropertyArrayHelper has no virtual destructor, the implementation of ~OPropertyArrayUsageHelper
-                assumes that you created an ::cppu::OPropertyArrayHelper when deleting s_pProps.
                 @return                         an pointer to the newly created array helper. Must not be NULL.
             */
             virtual ::cppu::IPropertyArrayHelper* createArrayHelper(sal_Int32 nId) const override;
diff --git a/include/comphelper/IdPropArrayHelper.hxx b/include/comphelper/IdPropArrayHelper.hxx
index 18367b0..a8b2f4e 100644
--- a/include/comphelper/IdPropArrayHelper.hxx
+++ b/include/comphelper/IdPropArrayHelper.hxx
@@ -74,9 +74,6 @@ namespace comphelper
             This method needs to be implemented in derived classes.
             <BR>
             The method gets called with Mutex acquired.
-            <BR>
-            as long as IPropertyArrayHelper has no virtual destructor, the implementation of ~OPropertyArrayUsageHelper
-            assumes that you created an ::cppu::OPropertyArrayHelper when deleting s_pProps.
             @return                         an pointer to the newly created array helper. Must not be NULL.
         */
         virtual ::cppu::IPropertyArrayHelper* createArrayHelper(sal_Int32 nId) const = 0;
diff --git a/include/comphelper/proparrhlp.hxx b/include/comphelper/proparrhlp.hxx
index 507c51b..3584553 100644
--- a/include/comphelper/proparrhlp.hxx
+++ b/include/comphelper/proparrhlp.hxx
@@ -57,9 +57,6 @@ protected:
         This method needs to be implemented in derived classes.
         <BR>
         The method gets called with Mutex acquired.
-        <BR>
-        as long as IPropertyArrayHelper has no virtual destructor, the implementation of ~OPropertyArrayUsageHelper
-        assumes that you created an ::cppu::OPropertyArrayHelper when deleting s_pProps.
         @return                         an pointer to the newly created array helper. Must not be NULL.
     */
     virtual ::cppu::IPropertyArrayHelper* createArrayHelper( ) const = 0;
diff --git a/mysqlc/source/mysqlc_subcomponent.hxx b/mysqlc/source/mysqlc_subcomponent.hxx
index 4041439..c19e693 100644
--- a/mysqlc/source/mysqlc_subcomponent.hxx
+++ b/mysqlc/source/mysqlc_subcomponent.hxx
@@ -112,9 +112,6 @@ namespace connectivity
                 This method needs to be implemented in derived classes.
                 <BR>
                 The method gets called with s_aMutex acquired.
-                <BR>
-                as long as IPropertyArrayHelper has no virtual destructor, the implementation of ~OPropertyArrayUsageHelper
-                assumes that you created an ::cppu::OPropertyArrayHelper when deleting s_pProps.
                 @return                         an pointer to the newly created array helper. Must not be NULL.
             */
             virtual ::cppu::IPropertyArrayHelper* createArrayHelper() const = 0;
diff --git a/odk/examples/DevelopersGuide/Database/DriverSkeleton/OSubComponent.hxx b/odk/examples/DevelopersGuide/Database/DriverSkeleton/OSubComponent.hxx
index 3d50a87..c31434e 100644
--- a/odk/examples/DevelopersGuide/Database/DriverSkeleton/OSubComponent.hxx
+++ b/odk/examples/DevelopersGuide/Database/DriverSkeleton/OSubComponent.hxx
@@ -129,9 +129,6 @@ namespace connectivity
                 This method needs to be implemented in derived classes.
                 <BR>
                 The method gets called with s_aMutex acquired.
-                <BR>
-                as long as IPropertyArrayHelper has no virtual destructor, the implementation of ~OPropertyArrayUsageHelper
-                assumes that you created an ::cppu::OPropertyArrayHelper when deleting s_pProps.
                 @return                         an pointer to the newly created array helper. Must not be NULL.
             */
             virtual ::cppu::IPropertyArrayHelper* createArrayHelper( ) const = 0;


More information about the Libreoffice-commits mailing list