[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp

[Tor Lillqvist]

 loolwsd/DocumentBroker.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit be22779c21fad4502b7b2ee5d624478a7ff3b66b
Author: Tor Lillqvist <tml at collabora.com>
Date:   Mon Oct 31 17:45:14 2016 +0200

    Assertion failures are for developers to read
    
    '_sessions.empty()' does not need a verbal explanation. We don't do
    those in other assertions in the same file anyway.
    
    (Also, I dislike the use of exclamation marks, especially in contexts
    that by themselves already are alerts, like in assertion failure
    messages. Exposure to LibreOffice source code with its style (in some
    neighbourhoods) of multiple exclamation marks, even, in comments,
    makes you like that. Exclamation marks makes your comments or messages
    look like check-out tabloid headlines.)

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 7516cc5..eda6eeb 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -171,7 +171,7 @@ DocumentBroker::~DocumentBroker()
                 << "] destroyed with " << _sessions.size()
                 << " sessions left." << Log::end;
 
-    assert(_sessions.empty() && "DocumentBroker still has unremoved sessions!");
+    assert(_sessions.empty());
 }
 
 bool DocumentBroker::load(const std::string& sessionId, const std::string& jailId)