[Libreoffice-commits] online.git: loolwsd/test

Ashod Nakashian ashod.nakashian at collabora.co.uk
Thu Sep 1 04:09:41 UTC 2016


 loolwsd/test/TileCacheTests.cpp |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 151d1ff955927d7770337e95d7b464136aa3c9e4
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Wed Aug 31 23:55:54 2016 -0400

    loolwsd: unittest fixes
    
    Change-Id: I7096b6dabfa59a536809c4e997168c8fce5791f0
    Reviewed-on: https://gerrit.libreoffice.org/28578
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
    Tested-by: Ashod Nakashian <ashnakash at gmail.com>

diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp
index f3d9564..d2bfa5e 100644
--- a/loolwsd/test/TileCacheTests.cpp
+++ b/loolwsd/test/TileCacheTests.cpp
@@ -443,16 +443,13 @@ void TileCacheTests::testTileInvalidateWriter()
     for (char ch : text)
     {
         sendChar(socket, ch); // Send ordinary characters and wait for response -> one tile invalidation for each
-        auto response = getResponseMessage(socket, "invalidatetiles:");
-        CPPUNIT_ASSERT_MESSAGE("did not receive a invalidatetiles: message as expected", !response.empty());
+        assertResponseLine(socket, "invalidatetiles:");
     }
 
     text = "\n\n\n";
     for (char ch : text)
     {
-        sendChar(socket, ch, skCtrl); // Send 3 Ctrl+Enter -> 3 new pages; I see 3 tiles invalidated for each
-        assertResponseLine(socket, "invalidatetiles:");
-        assertResponseLine(socket, "invalidatetiles:");
+        sendChar(socket, ch, skCtrl); // Send 3 Ctrl+Enter -> 3 new pages
         assertResponseLine(socket, "invalidatetiles:");
     }
 
@@ -460,8 +457,7 @@ void TileCacheTests::testTileInvalidateWriter()
     for (char ch : text)
     {
         sendChar(socket, ch);
-        auto response = getResponseMessage(socket, "invalidatetiles:");
-        CPPUNIT_ASSERT_MESSAGE("did not receive a invalidatetiles: message as expected", !response.empty());
+        assertResponseLine(socket, "invalidatetiles:");
     }
 
     // While extra invalidates are not desirable, they are inevitable at the moment.


More information about the Libreoffice-commits mailing list