[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - svtools/source

Caolán McNamara caolanm at redhat.com
Fri Sep 2 16:32:41 UTC 2016


 svtools/source/control/valueset.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 934c79c22ee63c25538e25b18d780377cc09f3af
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Aug 31 10:58:49 2016 +0100

    Resolves: tdf#98100 no valueset tooltips with extended tips...
    
    and no offline help available. I feel this was the original
    (day-0-checkin) intent of the code, otherwise why bother with
    the "| HelpEventMode::BALLOON" as that makes no difference
    to the existing logic. And this per-item help is what other
    similiar widgets do.
    
    Change-Id: Idda130450db322acefd9ecc13986067790f9a614
    (cherry picked from commit 281027ea88d4d683449d4ce2cdb0563223741465)
    Reviewed-on: https://gerrit.libreoffice.org/28542
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/svtools/source/control/valueset.cxx b/svtools/source/control/valueset.cxx
index e3bdbeb..d411eea 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -1494,7 +1494,7 @@ void ValueSet::Resize()
 
 void ValueSet::RequestHelp( const HelpEvent& rHelpEvent )
 {
-    if ( (rHelpEvent.GetMode() & (HelpEventMode::QUICK | HelpEventMode::BALLOON)) == HelpEventMode::QUICK )
+    if (rHelpEvent.GetMode() & (HelpEventMode::QUICK | HelpEventMode::BALLOON))
     {
         Point aPos = ScreenToOutputPixel( rHelpEvent.GetMousePosPixel() );
         size_t nItemPos = ImplGetItem( aPos );


More information about the Libreoffice-commits mailing list