[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - extensions/source

[Markus Mohrhard]

 extensions/source/update/check/updatecheck.cxx |    6 ++++++
 1 file changed, 6 insertions(+)

New commits:
commit 08f79e4686b97b8dae4acf0a804b8bbd1c29dd34
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Mon Aug 8 04:44:09 2016 +0200

    it is possible that Sources is empty
    
    See e.g.
    http://crashreport.libreoffice.org/stats/crash_details/570429b8-21e3-494e-9677-ea95fa8a5293
    
    Change-Id: I8c05efd61fa5a91511c06c660c49a0c470a96c88
    Reviewed-on: https://gerrit.libreoffice.org/27947
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Tested-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Reviewed-on: https://gerrit.libreoffice.org/28753
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/extensions/source/update/check/updatecheck.cxx b/extensions/source/update/check/updatecheck.cxx
index 8fe2363..86dc5c5 100644
--- a/extensions/source/update/check/updatecheck.cxx
+++ b/extensions/source/update/check/updatecheck.cxx
@@ -846,6 +846,12 @@ UpdateCheck::download()
     State eState = m_eState;
     aGuard.clear();
 
+    if (aInfo.Sources.empty())
+    {
+        SAL_WARN("extension.updatecheck", "download called without source");
+        return;
+    }
+
     if( aInfo.Sources[0].IsDirect )
     {
         // Ignore second click of a double click